You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2003/11/21 12:03:12 UTC
[jira] Updated: (MAVEN-1045) [patch] genapp should include .cvsignore of template
The following issue has been updated:
Updater: Jörg Schaible (mailto:joerg.schaible@elsag-solutions.com)
Date: Fri, 21 Nov 2003 5:03 AM
Comment:
Added patch as attachment because of white space handling in the HTML comment.
Changes:
Attachment changed to plugin.jelly.diff
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/secure/ViewIssue.jspa?key=MAVEN-1045&page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/secure/ViewIssue.jspa?key=MAVEN-1045
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MAVEN-1045
Summary: [patch] genapp should include .cvsignore of template
Type: Improvement
Status: Unassigned
Priority: Major
Original Estimate: 5 minutes
Time Spent: Unknown
Remaining: 5 minutes
Project: maven
Components:
plugin-genapp
Versions:
1.0-rc2
Assignee:
Reporter: Jörg Schaible
Created: Thu, 20 Nov 2003 9:04 AM
Updated: Fri, 21 Nov 2003 5:03 AM
Environment: N/A
Description:
If a project template includes a .cvsignore, it should not be ignored creating a new application. Escpecially since it is normally used to prevent maven generated log files from beeing checked in.
Problem is the copy task of Ant that has default excludes and .cvsignore is filtered out. Therefore I've added another copy rule without default excludes to include any valid .* file of the template. A separate rule is necessary because of the used include elements in the copy task.
Patch:
============ snip ==========
$ cvs diff -u plugin.jelly
Index: plugin.jelly
===================================================================
RCS file: /home/cvspublic/maven-plugins/genapp/plugin.jelly,v
retrieving revision 1.3
diff -u -r1.3 plugin.jelly
--- plugin.jelly 25 Aug 2003 09:43:14 -0000 1.3
+++ plugin.jelly 20 Nov 2003 15:01:00 -0000
@@ -119,6 +119,17 @@
</j:forEach>
</ant:fileset>
</ant:copy>
+
+ <!-- copy config files normally excluded by Ant default excludes -->
+ <ant:copy todir="${basedir}">
+ <ant:fileset dir="${maven.genapp.resources}" defaultexcludes="no">
+ <ant:include name="**/.*"/>
+ <ant:exclude name="**/.svn/**"/>
+ <ant:exclude name="**/*~"/>
+ <ant:exclude name="**/*.bak"/>
+ <ant:exclude name="**/*.swp"/>
+ </ant:fileset>
+ </ant:copy>
<!-- Run the specific jelly script for the template -->
<u:available file="${maven.genapp.template.dir}/template.jelly">
============ snap ==========
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org