You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/02/22 05:01:03 UTC

[GitHub] [maven-dependency-analyzer] chonton opened a new pull request #53: MSHARED-1037: CONSTANT_METHOD_TYPE should not add to classes

chonton opened a new pull request #53:
URL: https://github.com/apache/maven-dependency-analyzer/pull/53


   In ConstantPoolParser, method type signatures should not be added as a class dependency
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-dependency-analyzer] slawekjaranowski commented on pull request #53: MSHARED-1037: CONSTANT_METHOD_TYPE should not add to classes

Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #53:
URL: https://github.com/apache/maven-dependency-analyzer/pull/53#issuecomment-1047483980


   Thanks. Will be good to add some of test. Unit or IT, of course we can extends existing one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-dependency-analyzer] slawekjaranowski merged pull request #53: MSHARED-1037: CONSTANT_METHOD_TYPE should not add to classes

Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged pull request #53:
URL: https://github.com/apache/maven-dependency-analyzer/pull/53


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-dependency-analyzer] chonton commented on pull request #53: MSHARED-1037: CONSTANT_METHOD_TYPE should not add to classes

Posted by GitBox <gi...@apache.org>.
chonton commented on pull request #53:
URL: https://github.com/apache/maven-dependency-analyzer/pull/53#issuecomment-1059503320


   unit tests added


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-dependency-analyzer] slawekjaranowski commented on pull request #53: MSHARED-1037: CONSTANT_METHOD_TYPE should not add to classes

Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #53:
URL: https://github.com/apache/maven-dependency-analyzer/pull/53#issuecomment-1059778138


   @chonton please resolve conflicts


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org