You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Evan Phoenix <ev...@fallingsnow.net> on 2006/04/13 01:00:44 UTC
[PATCH] [RUBY] new typemaps
This patch adds a couple of new SWIG typemaps so that everywhere that
can receive a delta editor works the same.
Also adds another entry to the MAY_BE_NULL char* list.
[[[
Add new SWIG typemaps for consistence.
Add a missing argument to the MAY_BE_NULL list.
* subversion/bindings/swig/ruby/svn_delta.c
* subversion/bindings/swig/ruby/svn_ra.c
SWIG autogenerated changes.
* subversion/bindings/swig/svn_delta.i
(const char *MAY_BE_NULL) text_checksum can optionally be NULL
* subversion/bindings/swig/svn_ra.i
Added typemaps for delta_editors with edit_baton, update_baton, and
diff_baton arguments. This allows any object to serve as editors in these
places. Code is actually duplicated from the same file, all that was done is
altering the name of the baton. Anywhere that accepts a delta_editor should
work the same now.
]]]
--
When I do good, I feel good; when I do bad, I feel bad,
and that is my religion.
-- Abraham Lincoln (1809 - 1865)
Re: [PATCH] [RUBY] new typemaps
Posted by Kouhei Sutou <ko...@cozmixng.org>.
Hi,
In <92...@mail.gmail.com>
"Re: [PATCH] [RUBY] new typemaps" on Wed, 12 Apr 2006 21:54:11 -0700,
"Evan Phoenix" <ev...@fallingsnow.net> wrote:
> I've been working with 1.3.1 instead of trunk because I want the
> application I'm building to work with 1.3.1.
In the situation, you can use 1.3.x branch.
Now, the changes I committed to trunk aren't applied to
1.3.x without nominating the changes to
https://svn.collab.net/repos/svn/branches/1.3.x/STATUS.
If you have some changes applied into 1.3.x, please tell me
the revision. I'll nominate the revision to STATUS.
Thanks,
--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] [RUBY] new typemaps
Posted by Evan Phoenix <ev...@fallingsnow.net>.
Kouhei,
I saw the commits, so I'm assuming that they answered your questions.
I'll write a patch to update the test cases as well. Should be able to
send those in in a few days.
I've been working with 1.3.1 instead of trunk because I want the
application I'm building to work with 1.3.1. In the future, I'll also
make patchs for trunk if they're different than ones for 1.x.
Thanks for committing them!
- Evan
On 4/12/06, Kouhei Sutou <ko...@cozmixng.org> wrote:
> Hi,
>
> Thanks for sending many patches.
>
> In <92...@mail.gmail.com>
> "[PATCH] [RUBY] new typemaps" on Wed, 12 Apr 2006 18:00:44 -0700,
> "Evan Phoenix" <ev...@fallingsnow.net> wrote:
>
> > This patch adds a couple of new SWIG typemaps so that everywhere that
> > can receive a delta editor works the same.
> >
> > Also adds another entry to the MAY_BE_NULL char* list.
>
> I prefer to have a change in a patch than some changes in a
> patch.
>
> > * subversion/bindings/swig/ruby/svn_delta.c
> > * subversion/bindings/swig/ruby/svn_ra.c
> > SWIG autogenerated changes.
>
> This files don't need.
> I suggest you use working copy of
> https://svn.collab.net/repos/svn/trunk.
>
> > * subversion/bindings/swig/svn_delta.i
> > (const char *MAY_BE_NULL) text_checksum can optionally be NULL
>
> Where is it needed?
>
> > * subversion/bindings/swig/svn_ra.i
> > Added typemaps for delta_editors with edit_baton, update_baton, and
> > diff_baton arguments. This allows any object to serve as editors in these
> > places. Code is actually duplicated from the same file, all that was done is
> > altering the name of the baton. Anywhere that accepts a delta_editor should
> > work the same now.
>
> Could you update test cases too?
>
>
> Thanks,
> --
> kou
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>
--
When I do good, I feel good; when I do bad, I feel bad,
and that is my religion.
-- Abraham Lincoln (1809 - 1865)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] [RUBY] new typemaps
Posted by Kouhei Sutou <ko...@cozmixng.org>.
Hi,
Thanks for sending many patches.
In <92...@mail.gmail.com>
"[PATCH] [RUBY] new typemaps" on Wed, 12 Apr 2006 18:00:44 -0700,
"Evan Phoenix" <ev...@fallingsnow.net> wrote:
> This patch adds a couple of new SWIG typemaps so that everywhere that
> can receive a delta editor works the same.
>
> Also adds another entry to the MAY_BE_NULL char* list.
I prefer to have a change in a patch than some changes in a
patch.
> * subversion/bindings/swig/ruby/svn_delta.c
> * subversion/bindings/swig/ruby/svn_ra.c
> SWIG autogenerated changes.
This files don't need.
I suggest you use working copy of
https://svn.collab.net/repos/svn/trunk.
> * subversion/bindings/swig/svn_delta.i
> (const char *MAY_BE_NULL) text_checksum can optionally be NULL
Where is it needed?
> * subversion/bindings/swig/svn_ra.i
> Added typemaps for delta_editors with edit_baton, update_baton, and
> diff_baton arguments. This allows any object to serve as editors in these
> places. Code is actually duplicated from the same file, all that was done is
> altering the name of the baton. Anywhere that accepts a delta_editor should
> work the same now.
Could you update test cases too?
Thanks,
--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org