[GitHub] [spark] yikf commented on a change in pull request #31227: [SPARK-34064][SQL] Cancel the running broadcast sub-jobs when SQL statement is cancelled

[GitBox <gi...@apache.org>]

yikf commented on a change in pull request #31227:
URL: https://github.com/apache/spark/pull/31227#discussion_r559564518



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala
##########
@@ -74,7 +74,9 @@ case class BroadcastExchangeExec(
     child: SparkPlan) extends BroadcastExchangeLike {
   import BroadcastExchangeExec._
 
-  override val runId: UUID = UUID.randomUUID
+  // runId must be a UUID. We set it to statementId if defined.
+  override val runId: UUID = Option(sparkContext.getLocalProperty(SparkContext.SPARK_STATEMENT_ID))

Review comment:
       Is it better that use `statementId ` instead of `runId`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org