You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/10/07 23:21:16 UTC
[kudu-CR] consensus: remove ConsensusFaultHooks
Hello David Ribeiro Alves,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4669
to review the following change.
Change subject: consensus: remove ConsensusFaultHooks
......................................................................
consensus: remove ConsensusFaultHooks
We never actually implemented tests that used these to inject faults,
and in fact we only used a single one of the "hooks" as a mechanism for
counting calls to Update(). I replaced that with a simple variable so
that we could remove all of this extra code.
Change-Id: I49880cb4492c5bd911099510d05b75995573fe1d
---
M src/kudu/consensus/consensus-test-util.h
M src/kudu/consensus/consensus.cc
M src/kudu/consensus/consensus.h
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/consensus/raft_consensus_quorum-test.cc
6 files changed, 15 insertions(+), 259 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/4669/1
--
To view, visit http://gerrit.cloudera.org:8080/4669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I49880cb4492c5bd911099510d05b75995573fe1d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] consensus: remove ConsensusFaultHooks
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: consensus: remove ConsensusFaultHooks
......................................................................
consensus: remove ConsensusFaultHooks
We never actually implemented tests that used these to inject faults,
and in fact we only used a single one of the "hooks" as a mechanism for
counting calls to Update(). I replaced that with a simple variable so
that we could remove all of this extra code.
Change-Id: I49880cb4492c5bd911099510d05b75995573fe1d
Reviewed-on: http://gerrit.cloudera.org:8080/4669
Reviewed-by: David Ribeiro Alves <dr...@apache.org>
Tested-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/consensus/consensus-test-util.h
M src/kudu/consensus/consensus.cc
M src/kudu/consensus/consensus.h
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/consensus/raft_consensus_quorum-test.cc
6 files changed, 15 insertions(+), 259 deletions(-)
Approvals:
David Ribeiro Alves: Looks good to me, approved
Todd Lipcon: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I49880cb4492c5bd911099510d05b75995573fe1d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] consensus: remove ConsensusFaultHooks
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: consensus: remove ConsensusFaultHooks
......................................................................
Patch Set 1: Verified+1
Unrelated failures due to the thirdparty directory being dirty on the slave.
--
To view, visit http://gerrit.cloudera.org:8080/4669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I49880cb4492c5bd911099510d05b75995573fe1d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] consensus: remove ConsensusFaultHooks
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: consensus: remove ConsensusFaultHooks
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I49880cb4492c5bd911099510d05b75995573fe1d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No