You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Ruediger Pluem <rp...@apache.org> on 2020/10/23 08:07:39 UTC
Re: svn commit: r1882776 - /httpd/httpd/trunk/.travis.yml
On 10/23/20 8:24 AM, rpluem@apache.org wrote:
> Author: rpluem
> Date: Fri Oct 23 06:24:55 2020
> New Revision: 1882776
>
> URL: http://svn.apache.org/viewvc?rev=1882776&view=rev
> Log:
> * Two first tests using Ubuntu Focal
>
> Modified:
> httpd/httpd/trunk/.travis.yml
>
> Modified: httpd/httpd/trunk/.travis.yml
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/.travis.yml?rev=1882776&r1=1882775&r2=1882776&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/.travis.yml (original)
> +++ httpd/httpd/trunk/.travis.yml Fri Oct 23 06:24:55 2020
> @@ -214,6 +214,18 @@ jobs:
> CONFIG="--enable-mods-shared=reallyall"
> APU_CONFIG="--with-crypto --with-ldap"
> # -------------------------------------------------------------------------
> + - if: *condition_24x_only
> + name: Linux Ubuntu Focal, all-modules, system APR/APR-util
> + os: linux
> + dist: focal
> + env: CONFIG="--enable-mods-shared=reallyall"
> + # -------------------------------------------------------------------------
> + - name: Linux Ubuntu Focal, all-modules, APR 1.7.0, APR-util 1.6.1
> + dist: focal
> + env: APR_VERSION=1.7.0 APU_VERSION=1.6.1
> + CONFIG="--enable-mods-shared=reallyall"
> + APU_CONFIG="--with-crypto --with-ldap"
> + # -------------------------------------------------------------------------
> - name: Linux Ubuntu, APR 1.7.0, APR-util 1.6.1
> env: APR_VERSION=1.7.0 APU_VERSION=1.6.1
> CONFIG="--enable-mods-shared=reallyall"
>
As Ubuntu Focal seems to work (https://travis-ci.org/github/apache/httpd/builds/738225395) I ask myself
what we should do now with regards to testing. Should we
1. Clone all Bionic tests and run them with Focal as well?
2. Switch the Bionic tests to Focal?
3. Do a mixture of 1. and 2.: Switch some Bionic tests to Focal and clone the ones we leave on Bionic to Focal?
Regards
Rüdiger
Re: svn commit: r1882776 - /httpd/httpd/trunk/.travis.yml
Posted by Ruediger Pluem <rp...@apache.org>.
On 11/2/20 6:02 PM, Joe Orton wrote:
> On Fri, Oct 30, 2020 at 09:25:05PM +0100, Ruediger Pluem wrote:
>> Are the following ones good candidates? They also do LDAP and SSL tests which could be interesting as I guess that Focal has newer
>> LDAP and SSL libs compared to Bionic:
>
> I'm a bit worried about running pool-debug tests more since they seem
> the most fragile, but yes probably worthwhile for these cases. Looks
> like Focal has OpenSSL 1.1.1f vs 1.1.1 on Bionic so definitely good valu
> in doing more on the SSL side.
Should we do the tests on Focal without pool-debug? I would be fine with this.
If I remove the pool debugging, does TEST_MALLOC still make sense?
>
> (really need a test with OpenSSL 3.0 branch as well somehow...)
>
>> # -------------------------------------------------------------------------
>> - name: Linux Ubuntu, APR 1.7.x, APR-util 1.7.x
>> env: APR_VERSION=1.7.x APU_VERSION=1.7.x
>> CONFIG="--enable-mods-shared=reallyall"
>> APU_CONFIG="--with-crypto --with-ldap"
>> CLEAR_CACHE=1
>> # -------------------------------------------------------------------------
>> - name: Linux Ubuntu, Shared MPMs (event), pool-debug, SSL/TLS variants
>> env: APR_VERSION=1.7.0 APR_CONFIG="--enable-pool-debug"
>> APU_VERSION=1.6.1 APU_CONFIG="--with-crypto --with-ldap"
>> CONFIG="--enable-mods-shared=reallyall --enable-mpms-shared=all --with-mpm=event"
>> TEST_MALLOC=1 TEST_SSL=1
>> # -------------------------------------------------------------------------
>> - name: Linux Ubuntu, APR 1.7.0, APR-util 1.6.1, pool-debug, LDAP
>> env: APR_VERSION=1.7.0 APR_CONFIG="--enable-pool-debug"
>> APU_VERSION=1.6.1 APU_CONFIG="--with-crypto --with-ldap"
>> CONFIG="--enable-mods-shared=reallyall"
>> TEST_MALLOC=1 TEST_LDAP=1 TEST_ARGS="-defines LDAP"
>> TESTS="t/modules/"
>>
>>
>> Does this one make sense on Focal as well / shift to Focal as we have likely a newer ubsan library there?
>>
>> - name: Linux Ubuntu, UBSan
>> env: NOTEST_CFLAGS="-fsanitize=undefined -fno-sanitize-recover=undefined" NOTEST_LIBS=-lubsan
>> CONFIG="--enable-mods-shared=reallyall --disable-http2" TEST_UBSAN=1
>
> Yes, I can't seemuch value in running that on multiple platforms so
> moving it to Focal makes sense.
r1883072
Regards
Rüdiger
Re: svn commit: r1882776 - /httpd/httpd/trunk/.travis.yml
Posted by Joe Orton <jo...@redhat.com>.
On Fri, Oct 30, 2020 at 09:25:05PM +0100, Ruediger Pluem wrote:
> Are the following ones good candidates? They also do LDAP and SSL tests which could be interesting as I guess that Focal has newer
> LDAP and SSL libs compared to Bionic:
I'm a bit worried about running pool-debug tests more since they seem
the most fragile, but yes probably worthwhile for these cases. Looks
like Focal has OpenSSL 1.1.1f vs 1.1.1 on Bionic so definitely good valu
in doing more on the SSL side.
(really need a test with OpenSSL 3.0 branch as well somehow...)
> # -------------------------------------------------------------------------
> - name: Linux Ubuntu, APR 1.7.x, APR-util 1.7.x
> env: APR_VERSION=1.7.x APU_VERSION=1.7.x
> CONFIG="--enable-mods-shared=reallyall"
> APU_CONFIG="--with-crypto --with-ldap"
> CLEAR_CACHE=1
> # -------------------------------------------------------------------------
> - name: Linux Ubuntu, Shared MPMs (event), pool-debug, SSL/TLS variants
> env: APR_VERSION=1.7.0 APR_CONFIG="--enable-pool-debug"
> APU_VERSION=1.6.1 APU_CONFIG="--with-crypto --with-ldap"
> CONFIG="--enable-mods-shared=reallyall --enable-mpms-shared=all --with-mpm=event"
> TEST_MALLOC=1 TEST_SSL=1
> # -------------------------------------------------------------------------
> - name: Linux Ubuntu, APR 1.7.0, APR-util 1.6.1, pool-debug, LDAP
> env: APR_VERSION=1.7.0 APR_CONFIG="--enable-pool-debug"
> APU_VERSION=1.6.1 APU_CONFIG="--with-crypto --with-ldap"
> CONFIG="--enable-mods-shared=reallyall"
> TEST_MALLOC=1 TEST_LDAP=1 TEST_ARGS="-defines LDAP"
> TESTS="t/modules/"
>
>
> Does this one make sense on Focal as well / shift to Focal as we have likely a newer ubsan library there?
>
> - name: Linux Ubuntu, UBSan
> env: NOTEST_CFLAGS="-fsanitize=undefined -fno-sanitize-recover=undefined" NOTEST_LIBS=-lubsan
> CONFIG="--enable-mods-shared=reallyall --disable-http2" TEST_UBSAN=1
Yes, I can't seemuch value in running that on multiple platforms so
moving it to Focal makes sense.
> >> Also the *condition_24x_only should be unnecessary for Focal which has
> >> APR 1.6 (sufficient for trunk). It's necessary for Xenial because that
> >> has a too-old APR to build trunk against.
> >
> > Condition removed in
>
> Condition removed in r1882999.
Thanks a lot!
Regards, Joe
Re: svn commit: r1882776 - /httpd/httpd/trunk/.travis.yml
Posted by Ruediger Pluem <rp...@apache.org>.
Hit send by accident too early.
On 10/30/20 9:14 PM, Rüdiger Plüm wrote:
>
>
> On 10/29/20 3:51 PM, Joe Orton wrote:
>> On Fri, Oct 23, 2020 at 10:07:39AM +0200, Ruediger Pluem wrote:
>>>
>>>
>>> On 10/23/20 8:24 AM, rpluem@apache.org wrote:
>>>> Author: rpluem
>>>> Date: Fri Oct 23 06:24:55 2020
>>>> New Revision: 1882776
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1882776&view=rev
>>>> Log:
>>>> * Two first tests using Ubuntu Focal
>>>>
>>>> Modified:
>>>> httpd/httpd/trunk/.travis.yml
>>>>
>>>> Modified: httpd/httpd/trunk/.travis.yml
>>>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/.travis.yml?rev=1882776&r1=1882775&r2=1882776&view=diff
>>>> ==============================================================================
>>>> --- httpd/httpd/trunk/.travis.yml (original)
>>>> +++ httpd/httpd/trunk/.travis.yml Fri Oct 23 06:24:55 2020
>>>> @@ -214,6 +214,18 @@ jobs:
>>>> CONFIG="--enable-mods-shared=reallyall"
>>>> APU_CONFIG="--with-crypto --with-ldap"
>>>> # -------------------------------------------------------------------------
>>>> + - if: *condition_24x_only
>>>> + name: Linux Ubuntu Focal, all-modules, system APR/APR-util
>>>> + os: linux
>>>> + dist: focal
>>>> + env: CONFIG="--enable-mods-shared=reallyall"
>>>> + # -------------------------------------------------------------------------
>>>> + - name: Linux Ubuntu Focal, all-modules, APR 1.7.0, APR-util 1.6.1
>>>> + dist: focal
>>>> + env: APR_VERSION=1.7.0 APU_VERSION=1.6.1
>>>> + CONFIG="--enable-mods-shared=reallyall"
>>>> + APU_CONFIG="--with-crypto --with-ldap"
>>>> + # -------------------------------------------------------------------------
>>>> - name: Linux Ubuntu, APR 1.7.0, APR-util 1.6.1
>>>> env: APR_VERSION=1.7.0 APU_VERSION=1.6.1
>>>> CONFIG="--enable-mods-shared=reallyall"
>>>>
>>>
>>> As Ubuntu Focal seems to work (https://travis-ci.org/github/apache/httpd/builds/738225395)
>>
>> Thanks for adding it!
>>
>>> I ask myself what we should do now with regards to testing. Should we
>>>
>>> 1. Clone all Bionic tests and run them with Focal as well?
>>> 2. Switch the Bionic tests to Focal?
>>> 3. Do a mixture of 1. and 2.: Switch some Bionic tests to Focal and clone the ones we leave on Bionic to Focal?
>>
>> I think it would be fine just running a couple of all-modules tests on
>> Focal, with built-APR and system-APR just as you've done it.
Are the following ones good candidates? They also do LDAP and SSL tests which could be interesting as I guess that Focal has newer
LDAP and SSL libs compared to Bionic:
# -------------------------------------------------------------------------
- name: Linux Ubuntu, APR 1.7.x, APR-util 1.7.x
env: APR_VERSION=1.7.x APU_VERSION=1.7.x
CONFIG="--enable-mods-shared=reallyall"
APU_CONFIG="--with-crypto --with-ldap"
CLEAR_CACHE=1
# -------------------------------------------------------------------------
- name: Linux Ubuntu, Shared MPMs (event), pool-debug, SSL/TLS variants
env: APR_VERSION=1.7.0 APR_CONFIG="--enable-pool-debug"
APU_VERSION=1.6.1 APU_CONFIG="--with-crypto --with-ldap"
CONFIG="--enable-mods-shared=reallyall --enable-mpms-shared=all --with-mpm=event"
TEST_MALLOC=1 TEST_SSL=1
# -------------------------------------------------------------------------
- name: Linux Ubuntu, APR 1.7.0, APR-util 1.6.1, pool-debug, LDAP
env: APR_VERSION=1.7.0 APR_CONFIG="--enable-pool-debug"
APU_VERSION=1.6.1 APU_CONFIG="--with-crypto --with-ldap"
CONFIG="--enable-mods-shared=reallyall"
TEST_MALLOC=1 TEST_LDAP=1 TEST_ARGS="-defines LDAP"
TESTS="t/modules/"
Does this one make sense on Focal as well / shift to Focal as we have likely a newer ubsan library there?
- name: Linux Ubuntu, UBSan
env: NOTEST_CFLAGS="-fsanitize=undefined -fno-sanitize-recover=undefined" NOTEST_LIBS=-lubsan
CONFIG="--enable-mods-shared=reallyall --disable-http2" TEST_UBSAN=1
>>
>> Also the *condition_24x_only should be unnecessary for Focal which has
>> APR 1.6 (sufficient for trunk). It's necessary for Xenial because that
>> has a too-old APR to build trunk against.
>
> Condition removed in
Condition removed in r1882999.
Regards
Rüdiger
Re: svn commit: r1882776 - /httpd/httpd/trunk/.travis.yml
Posted by Rüdiger Plüm <r....@gmx.de>.
On 10/29/20 3:51 PM, Joe Orton wrote:
> On Fri, Oct 23, 2020 at 10:07:39AM +0200, Ruediger Pluem wrote:
>>
>>
>> On 10/23/20 8:24 AM, rpluem@apache.org wrote:
>>> Author: rpluem
>>> Date: Fri Oct 23 06:24:55 2020
>>> New Revision: 1882776
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1882776&view=rev
>>> Log:
>>> * Two first tests using Ubuntu Focal
>>>
>>> Modified:
>>> httpd/httpd/trunk/.travis.yml
>>>
>>> Modified: httpd/httpd/trunk/.travis.yml
>>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/.travis.yml?rev=1882776&r1=1882775&r2=1882776&view=diff
>>> ==============================================================================
>>> --- httpd/httpd/trunk/.travis.yml (original)
>>> +++ httpd/httpd/trunk/.travis.yml Fri Oct 23 06:24:55 2020
>>> @@ -214,6 +214,18 @@ jobs:
>>> CONFIG="--enable-mods-shared=reallyall"
>>> APU_CONFIG="--with-crypto --with-ldap"
>>> # -------------------------------------------------------------------------
>>> + - if: *condition_24x_only
>>> + name: Linux Ubuntu Focal, all-modules, system APR/APR-util
>>> + os: linux
>>> + dist: focal
>>> + env: CONFIG="--enable-mods-shared=reallyall"
>>> + # -------------------------------------------------------------------------
>>> + - name: Linux Ubuntu Focal, all-modules, APR 1.7.0, APR-util 1.6.1
>>> + dist: focal
>>> + env: APR_VERSION=1.7.0 APU_VERSION=1.6.1
>>> + CONFIG="--enable-mods-shared=reallyall"
>>> + APU_CONFIG="--with-crypto --with-ldap"
>>> + # -------------------------------------------------------------------------
>>> - name: Linux Ubuntu, APR 1.7.0, APR-util 1.6.1
>>> env: APR_VERSION=1.7.0 APU_VERSION=1.6.1
>>> CONFIG="--enable-mods-shared=reallyall"
>>>
>>
>> As Ubuntu Focal seems to work (https://travis-ci.org/github/apache/httpd/builds/738225395)
>
> Thanks for adding it!
>
>> I ask myself what we should do now with regards to testing. Should we
>>
>> 1. Clone all Bionic tests and run them with Focal as well?
>> 2. Switch the Bionic tests to Focal?
>> 3. Do a mixture of 1. and 2.: Switch some Bionic tests to Focal and clone the ones we leave on Bionic to Focal?
>
> I think it would be fine just running a couple of all-modules tests on
> Focal, with built-APR and system-APR just as you've done it.
>
> Also the *condition_24x_only should be unnecessary for Focal which has
> APR 1.6 (sufficient for trunk). It's necessary for Xenial because that
> has a too-old APR to build trunk against.
Condition removed in
Regards
Rüdiger
Re: svn commit: r1882776 - /httpd/httpd/trunk/.travis.yml
Posted by Joe Orton <jo...@redhat.com>.
On Fri, Oct 23, 2020 at 10:07:39AM +0200, Ruediger Pluem wrote:
>
>
> On 10/23/20 8:24 AM, rpluem@apache.org wrote:
> > Author: rpluem
> > Date: Fri Oct 23 06:24:55 2020
> > New Revision: 1882776
> >
> > URL: http://svn.apache.org/viewvc?rev=1882776&view=rev
> > Log:
> > * Two first tests using Ubuntu Focal
> >
> > Modified:
> > httpd/httpd/trunk/.travis.yml
> >
> > Modified: httpd/httpd/trunk/.travis.yml
> > URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/.travis.yml?rev=1882776&r1=1882775&r2=1882776&view=diff
> > ==============================================================================
> > --- httpd/httpd/trunk/.travis.yml (original)
> > +++ httpd/httpd/trunk/.travis.yml Fri Oct 23 06:24:55 2020
> > @@ -214,6 +214,18 @@ jobs:
> > CONFIG="--enable-mods-shared=reallyall"
> > APU_CONFIG="--with-crypto --with-ldap"
> > # -------------------------------------------------------------------------
> > + - if: *condition_24x_only
> > + name: Linux Ubuntu Focal, all-modules, system APR/APR-util
> > + os: linux
> > + dist: focal
> > + env: CONFIG="--enable-mods-shared=reallyall"
> > + # -------------------------------------------------------------------------
> > + - name: Linux Ubuntu Focal, all-modules, APR 1.7.0, APR-util 1.6.1
> > + dist: focal
> > + env: APR_VERSION=1.7.0 APU_VERSION=1.6.1
> > + CONFIG="--enable-mods-shared=reallyall"
> > + APU_CONFIG="--with-crypto --with-ldap"
> > + # -------------------------------------------------------------------------
> > - name: Linux Ubuntu, APR 1.7.0, APR-util 1.6.1
> > env: APR_VERSION=1.7.0 APU_VERSION=1.6.1
> > CONFIG="--enable-mods-shared=reallyall"
> >
>
> As Ubuntu Focal seems to work (https://travis-ci.org/github/apache/httpd/builds/738225395)
Thanks for adding it!
> I ask myself what we should do now with regards to testing. Should we
>
> 1. Clone all Bionic tests and run them with Focal as well?
> 2. Switch the Bionic tests to Focal?
> 3. Do a mixture of 1. and 2.: Switch some Bionic tests to Focal and clone the ones we leave on Bionic to Focal?
I think it would be fine just running a couple of all-modules tests on
Focal, with built-APR and system-APR just as you've done it.
Also the *condition_24x_only should be unnecessary for Focal which has
APR 1.6 (sufficient for trunk). It's necessary for Xenial because that
has a too-old APR to build trunk against.
Regards, Joe