You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yuluo-yx (via GitHub)" <gi...@apache.org> on 2026/08/20 16:09:00 UTC
[PR] [ISSUE #2462] fix(a11y): label information banners [rocketmq-dashboard]
yuluo-yx opened a new pull request, #2466:
URL: https://github.com/apache/rocketmq-dashboard/pull/2466
## Summary\n\n- expose persistent information banners as accessible notes\n- associate visible banner titles with the note container\n- avoid dangling or language-specific labels when no title is supplied\n\n## Verification\n\n- InfoBanner.test.tsx: 1 test passed\n- targeted ESLint and Prettier checks passed\n- scope check: 40 changed lines\n\nFixes #2462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #2462] fix(a11y): label information banners [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #2466:
URL: https://github.com/apache/rocketmq-dashboard/pull/2466#issuecomment-5434900335
Thanks for the fixes — they were reviewed individually and most look good. However, for this many small single-commit changes we prefer contributors to consolidate related fixes into a few cohesive pull requests following the contribution guidelines, instead of submitting them separately.
Closing for now. Please regroup these changes by functional area (e.g. backend normalization, Aliyun provider, frontend components, frontend data/config, deploy scripts) into a small number of PRs and resubmit — the individual commits reviewed here can be reused as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #2462] fix(a11y): label information banners [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #2466: [ISSUE #2462] fix(a11y): label information banners
URL: https://github.com/apache/rocketmq-dashboard/pull/2466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org