You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mrhhsg (via GitHub)" <gi...@apache.org> on 2026/05/18 09:41:54 UTC
[PR] [fix](be) Reject invalid JSONB path syntax [doris]
mrhhsg opened a new pull request, #63364:
URL: https://github.com/apache/doris/pull/63364
### What problem does this PR solve?
Issue Number: DORIS-25580
Related PR: None
Problem Summary: Reject JSONB paths with fractional array indexes, case-mismatched `last` keyword, and dot-bracket array syntax so invalid paths fail instead of returning silent values.
### Release note
Reject invalid JSONB path expressions that were previously accepted silently.
### Check List (For Author)
- Test:
- Unit Test: `./run-be-ut.sh --run --filter=JsonbPathTest.*`
- Regression test: `~/.codex/skills/doris-local-regression/scripts/doris-local-regression.sh run -d jsonb_p0 -s test_jsonb_invalid_path_syntax`
- Manual test: `./build.sh --be`
- Behavior changed: Yes. Invalid JSONB path expressions now return an error.
- Does this need documentation: No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [doc](be) Document JSONB path compatibility [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #63364:
URL: https://github.com/apache/doris/pull/63364#issuecomment-4477818614
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [doc](be) Document JSONB path compatibility [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63364:
URL: https://github.com/apache/doris/pull/63364#issuecomment-4484699803
<details>
<summary>TPC-DS: <b>Total hot run time: 169494 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3fd913c7b01c9ad49d28378ee480e2a9937f676a, data reload: false
query5 4348 657 508 508
query6 348 217 193 193
query7 4234 557 316 316
query8 334 230 224 224
query9 8832 4111 4080 4080
query10 450 338 286 286
query11 5816 2386 2183 2183
query12 186 131 130 130
query13 1276 612 425 425
query14 6051 5360 5054 5054
query14_1 4377 4649 4289 4289
query15 221 198 185 185
query16 1027 467 394 394
query17 1118 720 592 592
query18 2551 493 345 345
query19 224 204 161 161
query20 146 139 130 130
query21 218 141 115 115
query22 13558 13578 13381 13381
query23 17274 16433 16028 16028
query23_1 16137 16133 16297 16133
query24 7414 1731 1304 1304
query24_1 1287 1284 1314 1284
query25 544 479 424 424
query26 1342 340 168 168
query27 2651 576 340 340
query28 4483 1964 1943 1943
query29 1008 646 530 530
query30 312 246 203 203
query31 1131 1046 942 942
query32 92 78 74 74
query33 569 354 304 304
query34 1158 1117 661 661
query35 776 782 671 671
query36 1313 1362 1168 1168
query37 154 109 98 98
query38 3236 3072 2994 2994
query39 947 939 894 894
query39_1 891 881 873 873
query40 229 153 131 131
query41 72 69 69 69
query42 112 114 110 110
query43 335 328 290 290
query44
query45 221 209 200 200
query46 1082 1172 729 729
query47 2341 2304 2235 2235
query48 409 420 282 282
query49 645 505 402 402
query50 1000 342 252 252
query51 4270 4324 4217 4217
query52 106 107 94 94
query53 260 287 207 207
query54 326 284 270 270
query55 95 97 85 85
query56 311 321 329 321
query57 1432 1408 1319 1319
query58 320 283 279 279
query59 1540 1596 1466 1466
query60 337 341 321 321
query61 185 177 176 176
query62 670 619 567 567
query63 287 202 203 202
query64 2431 782 626 626
query65
query66 1695 484 340 340
query67 30046 30008 29824 29824
query68
query69 454 335 307 307
query70 1023 989 954 954
query71 312 275 271 271
query72 2973 2691 2437 2437
query73 851 742 416 416
query74 5075 4888 4759 4759
query75 2720 2591 2226 2226
query76 2298 1142 761 761
query77 395 406 333 333
query78 12260 12032 11566 11566
query79 1427 1022 751 751
query80 628 544 453 453
query81 467 276 242 242
query82 1379 160 123 123
query83 354 284 246 246
query84 269 136 107 107
query85 871 524 442 442
query86 395 338 337 337
query87 3416 3325 3171 3171
query88 3513 2659 2629 2629
query89 430 378 340 340
query90 1997 183 176 176
query91 188 160 136 136
query92 79 73 70 70
query93 1492 1497 864 864
query94 539 357 314 314
query95 687 383 354 354
query96 1002 761 336 336
query97 2690 2738 2557 2557
query98 241 236 228 228
query99 1132 1101 1003 1003
Total cold run time: 253430 ms
Total hot run time: 169494 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [doc](be) Document JSONB path compatibility [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63364:
URL: https://github.com/apache/doris/pull/63364#issuecomment-4485497995
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63364_3fd913c7b01c9ad49d28378ee480e2a9937f676a_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63364_3fd913c7b01c9ad49d28378ee480e2a9937f676a_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 57.63% (21845/37908) |
| Line Coverage | 40.94% (215224/525649) |
| Region Coverage | 37.44% (173194/462574) |
| Branch Coverage | 38.28% (74383/194338) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [doc](be) Document JSONB path compatibility [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg merged PR #63364:
URL: https://github.com/apache/doris/pull/63364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [doc](be) Document JSONB path compatibility [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63364:
URL: https://github.com/apache/doris/pull/63364#issuecomment-4485952307
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63364_3fd913c7b01c9ad49d28378ee480e2a9937f676a_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63364_3fd913c7b01c9ad49d28378ee480e2a9937f676a_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 57.63% (21845/37908) |
| Line Coverage | 40.94% (215224/525649) |
| Region Coverage | 37.44% (173194/462574) |
| Branch Coverage | 38.28% (74383/194338) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [doc](be) Document JSONB path compatibility [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #63364:
URL: https://github.com/apache/doris/pull/63364#issuecomment-4484158798
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [doc](be) Document JSONB path compatibility [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63364:
URL: https://github.com/apache/doris/pull/63364#issuecomment-4484641385
<details>
<summary>TPC-H: <b>Total hot run time: 31369 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3fd913c7b01c9ad49d28378ee480e2a9937f676a, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17651 3934 3954 3934
q2 q3 10764 1407 822 822
q4 4687 472 348 348
q5 7563 2236 2159 2159
q6 245 181 146 146
q7 972 787 645 645
q8 9355 1707 1621 1621
q9 5372 4913 4915 4913
q10 6431 2071 1812 1812
q11 448 280 258 258
q12 667 418 298 298
q13 18171 3406 2837 2837
q14 271 260 237 237
q15 q16 825 788 716 716
q17 852 941 1022 941
q18 6844 5681 5489 5489
q19 1182 1225 1132 1132
q20 524 421 256 256
q21 5655 2611 2492 2492
q22 430 374 313 313
Total cold run time: 98909 ms
Total hot run time: 31369 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4264 4286 4108 4108
q2 q3 4469 4942 4283 4283
q4 2090 2212 1384 1384
q5 4382 4263 4241 4241
q6 230 182 134 134
q7 1769 2252 1769 1769
q8 2624 2142 2160 2142
q9 7988 8038 7681 7681
q10 4565 4500 4106 4106
q11 551 432 386 386
q12 727 774 543 543
q13 3325 3640 2927 2927
q14 302 295 285 285
q15 q16 749 737 641 641
q17 1358 1352 1321 1321
q18 7956 7223 7331 7223
q19 1206 1138 1136 1136
q20 2212 2225 1937 1937
q21 5380 4667 4948 4667
q22 544 483 409 409
Total cold run time: 56691 ms
Total hot run time: 51323 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Reject invalid JSONB path syntax [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63364:
URL: https://github.com/apache/doris/pull/63364#issuecomment-4476396049
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org