You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/10/22 09:57:58 UTC

[GitHub] [skywalking] wu-sheng commented on pull request #7985: [WIP]Add MicroBench module to make it easier for developers to write JMH Test

wu-sheng commented on pull request #7985:
URL: https://github.com/apache/skywalking/pull/7985#issuecomment-949471788


   Moving the benchmark classes into another separate module makes me feeling super strange. Could you explain why? This module could be excluded(in default) from dist binary, and provide as `test` scope dependency for other modules.
   
   I also mentioned `server-testing`, which is providing this. Could you explain why you can't provide the basic codes into there?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org