You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/12/16 12:16:14 UTC

[GitHub] [commons-io] michielgkalkman commented on pull request #174: Restructure moveDirectoryToDirectory

michielgkalkman commented on pull request #174:
URL: https://github.com/apache/commons-io/pull/174#issuecomment-746200897


   No, in the original code, when the destination directory already exists, you do an exists() on this directory in lines 2173 and 2178 before isDirectory() is executed.
   
   However, isDirectory() can be executed right away (it does an exists() itself) and thus you skip two calls to exists().
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org