You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Mengwei Ding <me...@cloudera.com> on 2013/05/31 01:36:22 UTC
Review Request: SQOOP-1028: remove poll-timeout parameter and add
'poll-timeout' option for sqoop
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11561/
-----------------------------------------------------------
Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
Description
-------
commit 4e011751033d565b8817edfe04757d9104e2f3a0
Author: Mengwei Ding <me...@cloudera.com>
Date: Thu May 30 16:30:53 2013 -0700
SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop
:100644 100644 979b892... 866f3b8... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 9414b7d... a583982... M client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
:100644 100644 f6d1267... 8bc41d2... M client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
:100644 100644 890ede1... 8eff046... M client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java
:100644 100644 f04b1fd... 04bcf45... M client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
:100644 100644 e328f9a... bbc8313... M client/src/main/resources/client-resource.properties
Diffs
-----
client/src/main/java/org/apache/sqoop/client/core/Constants.java 979b892
client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java 9414b7d
client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java f6d1267
client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java 890ede1
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java f04b1fd
client/src/main/resources/client-resource.properties e328f9a
Diff: https://reviews.apache.org/r/11561/diff/
Testing
-------
Thanks,
Mengwei Ding
Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add
'poll-timeout' option for sqoop
Posted by Mengwei Ding <me...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11561/#review21215
-----------------------------------------------------------
client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
<https://reviews.apache.org/r/11561/#comment44068>
I know this wild long value is not good, but I really know where to put this constants. Can you guys help me with some suggestions? It will be greatly appreciated.
I have thought about add a constant variable in the Constants.java or even in property files. However, there is no similar constant variable existing in any of these 2 files. So I really have no idea which way, these 2 or some other ways, is better.
- Mengwei Ding
On May 30, 2013, 11:36 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11561/
> -----------------------------------------------------------
>
> (Updated May 30, 2013, 11:36 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit 4e011751033d565b8817edfe04757d9104e2f3a0
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Thu May 30 16:30:53 2013 -0700
>
> SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop
>
> :100644 100644 979b892... 866f3b8... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 9414b7d... a583982... M client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
> :100644 100644 f6d1267... 8bc41d2... M client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
> :100644 100644 890ede1... 8eff046... M client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java
> :100644 100644 f04b1fd... 04bcf45... M client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 100644 e328f9a... bbc8313... M client/src/main/resources/client-resource.properties
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 979b892
> client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java 9414b7d
> client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java f6d1267
> client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java 890ede1
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java f04b1fd
> client/src/main/resources/client-resource.properties e328f9a
>
> Diff: https://reviews.apache.org/r/11561/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add
'poll-timeout' option for sqoop
Posted by Mengwei Ding <me...@cloudera.com>.
> On May 30, 2013, 11:52 p.m., Abraham Elmahrek wrote:
> > client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java, lines 76-77
> > <https://reviews.apache.org/r/11561/diff/1/?file=299231#file299231line76>
> >
> > Instead of using a default value, why not simply return? That way, the default value will not be hard coded in multiple files.
>
> Mengwei Ding wrote:
> Yeah, this is a good one.
I had another thought about this issue, Abe. The reason why I did not directly return is that for any new value or default value, the following logic is going to output the value as a feedback to user.
- Mengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11561/#review21216
-----------------------------------------------------------
On June 4, 2013, 11:46 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11561/
> -----------------------------------------------------------
>
> (Updated June 4, 2013, 11:46 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit 6d2a4bb0331210cda99d571579705084b12fb357
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Thu May 30 16:30:53 2013 -0700
>
> SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop
>
> :100644 100644 979b892... 866f3b8... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 9414b7d... e843ede... M client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
> :100644 100644 5dbcef5... 79cd8b2... M client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
> :100644 100644 246937c... 81c5612... M client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java
> :100644 100644 f04b1fd... 04bcf45... M client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 100644 e328f9a... bbc8313... M client/src/main/resources/client-resource.properties
> :100644 100644 33419b9... 2158458... M docs/src/site/sphinx/CommandLineClient.rst
>
>
> This addresses bug SQOOP-1028.
> https://issues.apache.org/jira/browse/SQOOP-1028
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 979b892
> client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java 9414b7d
> client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java 5dbcef5
> client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java 246937c
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java f04b1fd
> client/src/main/resources/client-resource.properties e328f9a
> docs/src/site/sphinx/CommandLineClient.rst 33419b9
>
> Diff: https://reviews.apache.org/r/11561/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add
'poll-timeout' option for sqoop
Posted by Mengwei Ding <me...@cloudera.com>.
> On May 30, 2013, 11:52 p.m., Abraham Elmahrek wrote:
> > client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java, lines 76-77
> > <https://reviews.apache.org/r/11561/diff/1/?file=299231#file299231line76>
> >
> > Instead of using a default value, why not simply return? That way, the default value will not be hard coded in multiple files.
Yeah, this is a good one.
- Mengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11561/#review21216
-----------------------------------------------------------
On May 30, 2013, 11:42 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11561/
> -----------------------------------------------------------
>
> (Updated May 30, 2013, 11:42 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit 4e011751033d565b8817edfe04757d9104e2f3a0
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Thu May 30 16:30:53 2013 -0700
>
> SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop
>
> :100644 100644 979b892... 866f3b8... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 9414b7d... a583982... M client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
> :100644 100644 f6d1267... 8bc41d2... M client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
> :100644 100644 890ede1... 8eff046... M client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java
> :100644 100644 f04b1fd... 04bcf45... M client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 100644 e328f9a... bbc8313... M client/src/main/resources/client-resource.properties
>
>
> This addresses bug SQOOP-1028.
> https://issues.apache.org/jira/browse/SQOOP-1028
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 979b892
> client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java 9414b7d
> client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java f6d1267
> client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java 890ede1
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java f04b1fd
> client/src/main/resources/client-resource.properties e328f9a
>
> Diff: https://reviews.apache.org/r/11561/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add
'poll-timeout' option for sqoop
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11561/#review21216
-----------------------------------------------------------
Please add the bug # to the review as well. Other than the small comment below... +1.
client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
<https://reviews.apache.org/r/11561/#comment44069>
Instead of using a default value, why not simply return? That way, the default value will not be hard coded in multiple files.
- Abraham Elmahrek
On May 30, 2013, 11:42 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11561/
> -----------------------------------------------------------
>
> (Updated May 30, 2013, 11:42 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit 4e011751033d565b8817edfe04757d9104e2f3a0
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Thu May 30 16:30:53 2013 -0700
>
> SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop
>
> :100644 100644 979b892... 866f3b8... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 9414b7d... a583982... M client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
> :100644 100644 f6d1267... 8bc41d2... M client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
> :100644 100644 890ede1... 8eff046... M client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java
> :100644 100644 f04b1fd... 04bcf45... M client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 100644 e328f9a... bbc8313... M client/src/main/resources/client-resource.properties
>
>
> This addresses bug SQOOP-1028.
> https://issues.apache.org/jira/browse/SQOOP-1028
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 979b892
> client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java 9414b7d
> client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java f6d1267
> client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java 890ede1
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java f04b1fd
> client/src/main/resources/client-resource.properties e328f9a
>
> Diff: https://reviews.apache.org/r/11561/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add
'poll-timeout' option for sqoop
Posted by Mengwei Ding <me...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11561/#review21219
-----------------------------------------------------------
client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
<https://reviews.apache.org/r/11561/#comment44074>
If given a invalid value, should I use the previous value, or default value?
Here, I use the default value.
If use previous value, newValue should be set in the following way:
newValue = getPollTimeout();
- Mengwei Ding
On May 30, 2013, 11:42 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11561/
> -----------------------------------------------------------
>
> (Updated May 30, 2013, 11:42 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit 4e011751033d565b8817edfe04757d9104e2f3a0
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Thu May 30 16:30:53 2013 -0700
>
> SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop
>
> :100644 100644 979b892... 866f3b8... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 9414b7d... a583982... M client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
> :100644 100644 f6d1267... 8bc41d2... M client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
> :100644 100644 890ede1... 8eff046... M client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java
> :100644 100644 f04b1fd... 04bcf45... M client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 100644 e328f9a... bbc8313... M client/src/main/resources/client-resource.properties
>
>
> This addresses bug SQOOP-1028.
> https://issues.apache.org/jira/browse/SQOOP-1028
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 979b892
> client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java 9414b7d
> client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java f6d1267
> client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java 890ede1
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java f04b1fd
> client/src/main/resources/client-resource.properties e328f9a
>
> Diff: https://reviews.apache.org/r/11561/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add
'poll-timeout' option for sqoop
Posted by Mengwei Ding <me...@cloudera.com>.
> On June 5, 2013, 12:24 a.m., Jarek Cecho wrote:
> > client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java, lines 76-77
> > <https://reviews.apache.org/r/11561/diff/2/?file=300861#file300861line76>
> >
> > What about throwing here exception about illegal input?
I don't think it's necessary to do this, cause when given a illegal value for the 'verbose' option, there is no exception either. Instead, it just set the option to be false by default and notify the user by one line output.
- Mengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11561/#review21449
-----------------------------------------------------------
On June 4, 2013, 11:46 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11561/
> -----------------------------------------------------------
>
> (Updated June 4, 2013, 11:46 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit 6d2a4bb0331210cda99d571579705084b12fb357
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Thu May 30 16:30:53 2013 -0700
>
> SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop
>
> :100644 100644 979b892... 866f3b8... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 9414b7d... e843ede... M client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
> :100644 100644 5dbcef5... 79cd8b2... M client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
> :100644 100644 246937c... 81c5612... M client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java
> :100644 100644 f04b1fd... 04bcf45... M client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 100644 e328f9a... bbc8313... M client/src/main/resources/client-resource.properties
> :100644 100644 33419b9... 2158458... M docs/src/site/sphinx/CommandLineClient.rst
>
>
> This addresses bug SQOOP-1028.
> https://issues.apache.org/jira/browse/SQOOP-1028
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 979b892
> client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java 9414b7d
> client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java 5dbcef5
> client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java 246937c
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java f04b1fd
> client/src/main/resources/client-resource.properties e328f9a
> docs/src/site/sphinx/CommandLineClient.rst 33419b9
>
> Diff: https://reviews.apache.org/r/11561/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add
'poll-timeout' option for sqoop
Posted by Jarek Cecho <ja...@apache.org>.
> On June 5, 2013, 12:24 a.m., Jarek Cecho wrote:
> > client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java, lines 76-77
> > <https://reviews.apache.org/r/11561/diff/2/?file=300861#file300861line76>
> >
> > What about throwing here exception about illegal input?
>
> Mengwei Ding wrote:
> I don't think it's necessary to do this, cause when given a illegal value for the 'verbose' option, there is no exception either. Instead, it just set the option to be false by default and notify the user by one line output.
Okej, that make sense.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11561/#review21449
-----------------------------------------------------------
On June 4, 2013, 11:46 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11561/
> -----------------------------------------------------------
>
> (Updated June 4, 2013, 11:46 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit 6d2a4bb0331210cda99d571579705084b12fb357
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Thu May 30 16:30:53 2013 -0700
>
> SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop
>
> :100644 100644 979b892... 866f3b8... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 9414b7d... e843ede... M client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
> :100644 100644 5dbcef5... 79cd8b2... M client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
> :100644 100644 246937c... 81c5612... M client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java
> :100644 100644 f04b1fd... 04bcf45... M client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 100644 e328f9a... bbc8313... M client/src/main/resources/client-resource.properties
> :100644 100644 33419b9... 2158458... M docs/src/site/sphinx/CommandLineClient.rst
>
>
> This addresses bug SQOOP-1028.
> https://issues.apache.org/jira/browse/SQOOP-1028
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 979b892
> client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java 9414b7d
> client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java 5dbcef5
> client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java 246937c
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java f04b1fd
> client/src/main/resources/client-resource.properties e328f9a
> docs/src/site/sphinx/CommandLineClient.rst 33419b9
>
> Diff: https://reviews.apache.org/r/11561/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add
'poll-timeout' option for sqoop
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11561/#review21449
-----------------------------------------------------------
client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
<https://reviews.apache.org/r/11561/#comment44433>
What about throwing here exception about illegal input?
- Jarek Cecho
On June 4, 2013, 11:46 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11561/
> -----------------------------------------------------------
>
> (Updated June 4, 2013, 11:46 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit 6d2a4bb0331210cda99d571579705084b12fb357
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Thu May 30 16:30:53 2013 -0700
>
> SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop
>
> :100644 100644 979b892... 866f3b8... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 9414b7d... e843ede... M client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
> :100644 100644 5dbcef5... 79cd8b2... M client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
> :100644 100644 246937c... 81c5612... M client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java
> :100644 100644 f04b1fd... 04bcf45... M client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 100644 e328f9a... bbc8313... M client/src/main/resources/client-resource.properties
> :100644 100644 33419b9... 2158458... M docs/src/site/sphinx/CommandLineClient.rst
>
>
> This addresses bug SQOOP-1028.
> https://issues.apache.org/jira/browse/SQOOP-1028
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 979b892
> client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java 9414b7d
> client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java 5dbcef5
> client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java 246937c
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java f04b1fd
> client/src/main/resources/client-resource.properties e328f9a
> docs/src/site/sphinx/CommandLineClient.rst 33419b9
>
> Diff: https://reviews.apache.org/r/11561/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add
'poll-timeout' option for sqoop
Posted by Mengwei Ding <me...@cloudera.com>.
> On June 5, 2013, 9:13 p.m., Jarek Cecho wrote:
> > Hi Mengwei, thank you very much for working on this JIRA. Please upload the patch to the JIRA and I'll commit it.
> >
> > Jarcec
Uploaded! :)
Mengwei
- Mengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11561/#review21495
-----------------------------------------------------------
On June 5, 2013, 5:27 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11561/
> -----------------------------------------------------------
>
> (Updated June 5, 2013, 5:27 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit d7787293082b398511b7d331fdd12c7ca682dc03
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Thu May 30 16:30:53 2013 -0700
>
> SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop
>
> :100644 100644 979b892... 866f3b8... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 9414b7d... e843ede... M client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
> :100644 100644 5dbcef5... 79cd8b2... M client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
> :100644 100644 246937c... 81c5612... M client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java
> :100644 100644 f04b1fd... 04bcf45... M client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 100644 e328f9a... bbc8313... M client/src/main/resources/client-resource.properties
> :100644 100644 33419b9... 721a6c0... M docs/src/site/sphinx/CommandLineClient.rst
>
>
> This addresses bug SQOOP-1028.
> https://issues.apache.org/jira/browse/SQOOP-1028
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 979b892
> client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java 9414b7d
> client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java 5dbcef5
> client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java 246937c
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java f04b1fd
> client/src/main/resources/client-resource.properties e328f9a
> docs/src/site/sphinx/CommandLineClient.rst 33419b9
>
> Diff: https://reviews.apache.org/r/11561/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add
'poll-timeout' option for sqoop
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11561/#review21495
-----------------------------------------------------------
Ship it!
Hi Mengwei, thank you very much for working on this JIRA. Please upload the patch to the JIRA and I'll commit it.
Jarcec
- Jarek Cecho
On June 5, 2013, 5:27 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11561/
> -----------------------------------------------------------
>
> (Updated June 5, 2013, 5:27 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit d7787293082b398511b7d331fdd12c7ca682dc03
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Thu May 30 16:30:53 2013 -0700
>
> SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop
>
> :100644 100644 979b892... 866f3b8... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 9414b7d... e843ede... M client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
> :100644 100644 5dbcef5... 79cd8b2... M client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
> :100644 100644 246937c... 81c5612... M client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java
> :100644 100644 f04b1fd... 04bcf45... M client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 100644 e328f9a... bbc8313... M client/src/main/resources/client-resource.properties
> :100644 100644 33419b9... 721a6c0... M docs/src/site/sphinx/CommandLineClient.rst
>
>
> This addresses bug SQOOP-1028.
> https://issues.apache.org/jira/browse/SQOOP-1028
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 979b892
> client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java 9414b7d
> client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java 5dbcef5
> client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java 246937c
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java f04b1fd
> client/src/main/resources/client-resource.properties e328f9a
> docs/src/site/sphinx/CommandLineClient.rst 33419b9
>
> Diff: https://reviews.apache.org/r/11561/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add
'poll-timeout' option for sqoop
Posted by Mengwei Ding <me...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11561/
-----------------------------------------------------------
(Updated June 5, 2013, 5:27 p.m.)
Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
Changes
-------
Add a more specific description for "poll-timeout" option.
Description (updated)
-------
commit d7787293082b398511b7d331fdd12c7ca682dc03
Author: Mengwei Ding <me...@cloudera.com>
Date: Thu May 30 16:30:53 2013 -0700
SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop
:100644 100644 979b892... 866f3b8... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 9414b7d... e843ede... M client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
:100644 100644 5dbcef5... 79cd8b2... M client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
:100644 100644 246937c... 81c5612... M client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java
:100644 100644 f04b1fd... 04bcf45... M client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
:100644 100644 e328f9a... bbc8313... M client/src/main/resources/client-resource.properties
:100644 100644 33419b9... 721a6c0... M docs/src/site/sphinx/CommandLineClient.rst
This addresses bug SQOOP-1028.
https://issues.apache.org/jira/browse/SQOOP-1028
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/core/Constants.java 979b892
client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java 9414b7d
client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java 5dbcef5
client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java 246937c
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java f04b1fd
client/src/main/resources/client-resource.properties e328f9a
docs/src/site/sphinx/CommandLineClient.rst 33419b9
Diff: https://reviews.apache.org/r/11561/diff/
Testing
-------
Thanks,
Mengwei Ding
Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add
'poll-timeout' option for sqoop
Posted by Mengwei Ding <me...@cloudera.com>.
> On June 5, 2013, 2:43 p.m., Jarek Cecho wrote:
> > docs/src/site/sphinx/CommandLineClient.rst, line 112
> > <https://reviews.apache.org/r/11561/diff/2/?file=300866#file300866line112>
> >
> > Nit: I would recommend putting here a note that the value is expected to be in milliseconds.
Sure! I was going to do that, too!
- Mengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11561/#review21481
-----------------------------------------------------------
On June 4, 2013, 11:46 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11561/
> -----------------------------------------------------------
>
> (Updated June 4, 2013, 11:46 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit 6d2a4bb0331210cda99d571579705084b12fb357
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Thu May 30 16:30:53 2013 -0700
>
> SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop
>
> :100644 100644 979b892... 866f3b8... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 9414b7d... e843ede... M client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
> :100644 100644 5dbcef5... 79cd8b2... M client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
> :100644 100644 246937c... 81c5612... M client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java
> :100644 100644 f04b1fd... 04bcf45... M client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 100644 e328f9a... bbc8313... M client/src/main/resources/client-resource.properties
> :100644 100644 33419b9... 2158458... M docs/src/site/sphinx/CommandLineClient.rst
>
>
> This addresses bug SQOOP-1028.
> https://issues.apache.org/jira/browse/SQOOP-1028
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 979b892
> client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java 9414b7d
> client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java 5dbcef5
> client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java 246937c
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java f04b1fd
> client/src/main/resources/client-resource.properties e328f9a
> docs/src/site/sphinx/CommandLineClient.rst 33419b9
>
> Diff: https://reviews.apache.org/r/11561/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add
'poll-timeout' option for sqoop
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11561/#review21481
-----------------------------------------------------------
Hi Mengwei,
thank you very much for working on this patch. I do have just one nit:
docs/src/site/sphinx/CommandLineClient.rst
<https://reviews.apache.org/r/11561/#comment44487>
Nit: I would recommend putting here a note that the value is expected to be in milliseconds.
Jarcec
- Jarek Cecho
On June 4, 2013, 11:46 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11561/
> -----------------------------------------------------------
>
> (Updated June 4, 2013, 11:46 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit 6d2a4bb0331210cda99d571579705084b12fb357
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Thu May 30 16:30:53 2013 -0700
>
> SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop
>
> :100644 100644 979b892... 866f3b8... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 9414b7d... e843ede... M client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
> :100644 100644 5dbcef5... 79cd8b2... M client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
> :100644 100644 246937c... 81c5612... M client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java
> :100644 100644 f04b1fd... 04bcf45... M client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
> :100644 100644 e328f9a... bbc8313... M client/src/main/resources/client-resource.properties
> :100644 100644 33419b9... 2158458... M docs/src/site/sphinx/CommandLineClient.rst
>
>
> This addresses bug SQOOP-1028.
> https://issues.apache.org/jira/browse/SQOOP-1028
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 979b892
> client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java 9414b7d
> client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java 5dbcef5
> client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java 246937c
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java f04b1fd
> client/src/main/resources/client-resource.properties e328f9a
> docs/src/site/sphinx/CommandLineClient.rst 33419b9
>
> Diff: https://reviews.apache.org/r/11561/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add
'poll-timeout' option for sqoop
Posted by Mengwei Ding <me...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11561/
-----------------------------------------------------------
(Updated June 4, 2013, 11:46 p.m.)
Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
Description (updated)
-------
commit 6d2a4bb0331210cda99d571579705084b12fb357
Author: Mengwei Ding <me...@cloudera.com>
Date: Thu May 30 16:30:53 2013 -0700
SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop
:100644 100644 979b892... 866f3b8... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 9414b7d... e843ede... M client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
:100644 100644 5dbcef5... 79cd8b2... M client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
:100644 100644 246937c... 81c5612... M client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java
:100644 100644 f04b1fd... 04bcf45... M client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
:100644 100644 e328f9a... bbc8313... M client/src/main/resources/client-resource.properties
:100644 100644 33419b9... 2158458... M docs/src/site/sphinx/CommandLineClient.rst
This addresses bug SQOOP-1028.
https://issues.apache.org/jira/browse/SQOOP-1028
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/core/Constants.java 979b892
client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java 9414b7d
client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java 5dbcef5
client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java 246937c
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java f04b1fd
client/src/main/resources/client-resource.properties e328f9a
docs/src/site/sphinx/CommandLineClient.rst 33419b9
Diff: https://reviews.apache.org/r/11561/diff/
Testing
-------
Thanks,
Mengwei Ding
Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add
'poll-timeout' option for sqoop
Posted by Mengwei Ding <me...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11561/
-----------------------------------------------------------
(Updated May 30, 2013, 11:42 p.m.)
Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
Description
-------
commit 4e011751033d565b8817edfe04757d9104e2f3a0
Author: Mengwei Ding <me...@cloudera.com>
Date: Thu May 30 16:30:53 2013 -0700
SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop
:100644 100644 979b892... 866f3b8... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 9414b7d... a583982... M client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
:100644 100644 f6d1267... 8bc41d2... M client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
:100644 100644 890ede1... 8eff046... M client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java
:100644 100644 f04b1fd... 04bcf45... M client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
:100644 100644 e328f9a... bbc8313... M client/src/main/resources/client-resource.properties
This addresses bug SQOOP-1028.
https://issues.apache.org/jira/browse/SQOOP-1028
Diffs
-----
client/src/main/java/org/apache/sqoop/client/core/Constants.java 979b892
client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java 9414b7d
client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java f6d1267
client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java 890ede1
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java f04b1fd
client/src/main/resources/client-resource.properties e328f9a
Diff: https://reviews.apache.org/r/11561/diff/
Testing
-------
Thanks,
Mengwei Ding