You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "Torsten Dettborn (JIRA)" <ji...@apache.org> on 2006/11/29 07:07:21 UTC

[jira] Created: (PLUTO-271) patch for Shared-Render-Parameter

patch for Shared-Render-Parameter
---------------------------------

                 Key: PLUTO-271
                 URL: http://issues.apache.org/jira/browse/PLUTO-271
             Project: Pluto
          Issue Type: New Feature
          Components: general
    Affects Versions: 1.1-286-COMPATIBILITY
            Reporter: Torsten Dettborn


This is a the new functionality for shared-render-parameter. You can see the description in the Specification in PLT. 14.2.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (PLUTO-271) patch for public-render-parameter

Posted by "Christian Raschka (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Raschka updated PLUTO-271:
------------------------------------

    Description: This is a the new functionality for public-render-parameter. You can see the description in the Specification in PLT. 14.2.  (was: This is a the new functionality for shared-render-parameter. You can see the description in the Specification in PLT. 14.2.)
        Summary: patch for public-render-parameter  (was: patch for Shared-Render-Parameter)

Renaming

> patch for public-render-parameter
> ---------------------------------
>
>                 Key: PLUTO-271
>                 URL: https://issues.apache.org/jira/browse/PLUTO-271
>             Project: Pluto
>          Issue Type: New Feature
>          Components: general
>    Affects Versions: 1.1-286-COMPATIBILITY
>            Reporter: Torsten Dettborn
>             Fix For: 1.1-286-COMPATIBILITY
>
>         Attachments: public_render_parameters.action_exposure.140607.patch, PublicRenderParameter120607.patch, sharedRenderParameter.291106.patch
>
>
> This is a the new functionality for public-render-parameter. You can see the description in the Specification in PLT. 14.2.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PLUTO-271) patch for Shared-Render-Parameter

Posted by "Torsten Dettborn (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/PLUTO-271?page=all ]

Torsten Dettborn updated PLUTO-271:
-----------------------------------

    Attachment: sharedRenderParameter.291106.patch

This patch is for the new functionality for shared render parameter.

> patch for Shared-Render-Parameter
> ---------------------------------
>
>                 Key: PLUTO-271
>                 URL: http://issues.apache.org/jira/browse/PLUTO-271
>             Project: Pluto
>          Issue Type: New Feature
>          Components: general
>    Affects Versions: 1.1-286-COMPATIBILITY
>            Reporter: Torsten Dettborn
>         Attachments: sharedRenderParameter.291106.patch
>
>
> This is a the new functionality for shared-render-parameter. You can see the description in the Specification in PLT. 14.2.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (PLUTO-271) patch for public-render-parameter

Posted by "Torsten Dettborn (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Torsten Dettborn closed PLUTO-271.
----------------------------------

    Resolution: Fixed

The work on public render parameter for 1.1-286-COMPABILITY branch is finished.

> patch for public-render-parameter
> ---------------------------------
>
>                 Key: PLUTO-271
>                 URL: https://issues.apache.org/jira/browse/PLUTO-271
>             Project: Pluto
>          Issue Type: New Feature
>          Components: general
>    Affects Versions: 1.1-286-COMPATIBILITY
>            Reporter: Torsten Dettborn
>             Fix For: 1.1-286-COMPATIBILITY
>
>         Attachments: jaxb_public_render_add_qname_name_and_alias.190807.patch, public_render_parameters.action_exposure.140607.patch, PublicRenderParameter120607.patch, sharedRenderParameter.291106.patch
>
>
> This is a the new functionality for public-render-parameter. You can see the description in the Specification in PLT. 14.2.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PLUTO-271) patch for Shared-Render-Parameter

Posted by "Tuomas Kiviaho (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tuomas Kiviaho updated PLUTO-271:
---------------------------------

    Attachment: public_render_parameters.action_exposure.140607.patch

Here's one bug I discovered from the previous patches.

Section PLT.11.1.1.4 Public Render Parameters states as follows:

"In order to allow co-ordination of render parameters with other portlets, within the same portlet application or across portlet applications, the portlet can declare public render parameters in its deployment descriptor using..."

Yet these render parameters can be accesses in ActionRequest. I believe this is not intended by the spec, although I couldn't find a better section than this to support my statement. 

The driver seems to take care of traditional render parameters by using a PortalServletRequest wrapper (trunk version works correctly). This approach can be used for public render parameters as well.  

Here's a simple patch (public_render_parameters.action_exposure) fixing the problem with PortalServletRequest. Now all kinds of render parameters require wrapping to be exposed. See PLUTO-267 for event phase patches in similar manner.

> patch for Shared-Render-Parameter
> ---------------------------------
>
>                 Key: PLUTO-271
>                 URL: https://issues.apache.org/jira/browse/PLUTO-271
>             Project: Pluto
>          Issue Type: New Feature
>          Components: general
>    Affects Versions: 1.1-286-COMPATIBILITY
>            Reporter: Torsten Dettborn
>             Fix For: 1.1-286-COMPATIBILITY
>
>         Attachments: public_render_parameters.action_exposure.140607.patch, PublicRenderParameter120607.patch, sharedRenderParameter.291106.patch
>
>
> This is a the new functionality for shared-render-parameter. You can see the description in the Specification in PLT. 14.2.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PLUTO-271) patch for public-render-parameter

Posted by "Christian Raschka (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Raschka updated PLUTO-271:
------------------------------------

    Attachment: jaxb_public_render_add_qname_name_and_alias.190807.patch

Added the choice of name/qname and alias to jaxb annotations

> patch for public-render-parameter
> ---------------------------------
>
>                 Key: PLUTO-271
>                 URL: https://issues.apache.org/jira/browse/PLUTO-271
>             Project: Pluto
>          Issue Type: New Feature
>          Components: general
>    Affects Versions: 1.1-286-COMPATIBILITY
>            Reporter: Torsten Dettborn
>             Fix For: 1.1-286-COMPATIBILITY
>
>         Attachments: jaxb_public_render_add_qname_name_and_alias.190807.patch, public_render_parameters.action_exposure.140607.patch, PublicRenderParameter120607.patch, sharedRenderParameter.291106.patch
>
>
> This is a the new functionality for public-render-parameter. You can see the description in the Specification in PLT. 14.2.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PLUTO-271) patch for Shared-Render-Parameter

Posted by "Torsten Dettborn (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Torsten Dettborn updated PLUTO-271:
-----------------------------------

    Attachment: PublicRenderParameter120607.patch

The patch includes the changes for the refactoring the name shared render parameter to public render parameter and the changes for the QNames in the deploymentdescriptor.
For design docs please take a look on this side:

http://hnsp.inf-bb.uni-jena.de/wiki_public/index.php/Public_Parameter

> patch for Shared-Render-Parameter
> ---------------------------------
>
>                 Key: PLUTO-271
>                 URL: https://issues.apache.org/jira/browse/PLUTO-271
>             Project: Pluto
>          Issue Type: New Feature
>          Components: general
>    Affects Versions: 1.1-286-COMPATIBILITY
>            Reporter: Torsten Dettborn
>             Fix For: 1.1-286-COMPATIBILITY
>
>         Attachments: PublicRenderParameter120607.patch, sharedRenderParameter.291106.patch
>
>
> This is a the new functionality for shared-render-parameter. You can see the description in the Specification in PLT. 14.2.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PLUTO-271) patch for Shared-Render-Parameter

Posted by "David DeWolf (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/PLUTO-271?page=all ]

David DeWolf updated PLUTO-271:
-------------------------------

    Fix Version/s: 1.1-286-COMPATIBILITY

> patch for Shared-Render-Parameter
> ---------------------------------
>
>                 Key: PLUTO-271
>                 URL: http://issues.apache.org/jira/browse/PLUTO-271
>             Project: Pluto
>          Issue Type: New Feature
>          Components: general
>    Affects Versions: 1.1-286-COMPATIBILITY
>            Reporter: Torsten Dettborn
>             Fix For: 1.1-286-COMPATIBILITY
>
>         Attachments: sharedRenderParameter.291106.patch
>
>
> This is a the new functionality for shared-render-parameter. You can see the description in the Specification in PLT. 14.2.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (PLUTO-271) patch for Shared-Render-Parameter

Posted by "Tuomas Kiviaho (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PLUTO-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504599 ] 

Tuomas Kiviaho commented on PLUTO-271:
--------------------------------------

Smalle note over public_render_parameters.action_exposure.140607.patch 

I noticed that event render parameters got just patched and wanted to note that  PortalServletRequest currently in branch which doesn't have the section commented as obsolete is of course better than what I had here pulled from the trunk, but both work nevertheless.

> patch for Shared-Render-Parameter
> ---------------------------------
>
>                 Key: PLUTO-271
>                 URL: https://issues.apache.org/jira/browse/PLUTO-271
>             Project: Pluto
>          Issue Type: New Feature
>          Components: general
>    Affects Versions: 1.1-286-COMPATIBILITY
>            Reporter: Torsten Dettborn
>             Fix For: 1.1-286-COMPATIBILITY
>
>         Attachments: public_render_parameters.action_exposure.140607.patch, PublicRenderParameter120607.patch, sharedRenderParameter.291106.patch
>
>
> This is a the new functionality for shared-render-parameter. You can see the description in the Specification in PLT. 14.2.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PLUTO-271) patch for public-render-parameter

Posted by "Craig Doremus (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PLUTO-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521395 ] 

Craig Doremus commented on PLUTO-271:
-------------------------------------

Applied jaxb_public_render_add_qname_name_and_alias.190807.patch to 1.1-286-trunk-merge branch in SVN revision 568061.

> patch for public-render-parameter
> ---------------------------------
>
>                 Key: PLUTO-271
>                 URL: https://issues.apache.org/jira/browse/PLUTO-271
>             Project: Pluto
>          Issue Type: New Feature
>          Components: general
>    Affects Versions: 1.1-286-COMPATIBILITY
>            Reporter: Torsten Dettborn
>             Fix For: 1.1-286-COMPATIBILITY
>
>         Attachments: jaxb_public_render_add_qname_name_and_alias.190807.patch, public_render_parameters.action_exposure.140607.patch, PublicRenderParameter120607.patch, sharedRenderParameter.291106.patch
>
>
> This is a the new functionality for public-render-parameter. You can see the description in the Specification in PLT. 14.2.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (PLUTO-271) patch for Shared-Render-Parameter

Posted by "Torsten Dettborn (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Torsten Dettborn reopened PLUTO-271:
------------------------------------


This re factors the shared render parameter name to public render parameter and solves some little bugs. The new implementation details can be shown on the following side:
http://hnsp.inf-bb.uni-jena.de/wiki_public/index.php/Public_Parameter

> patch for Shared-Render-Parameter
> ---------------------------------
>
>                 Key: PLUTO-271
>                 URL: https://issues.apache.org/jira/browse/PLUTO-271
>             Project: Pluto
>          Issue Type: New Feature
>          Components: general
>    Affects Versions: 1.1-286-COMPATIBILITY
>            Reporter: Torsten Dettborn
>             Fix For: 1.1-286-COMPATIBILITY
>
>         Attachments: sharedRenderParameter.291106.patch
>
>
> This is a the new functionality for shared-render-parameter. You can see the description in the Specification in PLT. 14.2.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PLUTO-271) patch for Shared-Render-Parameter

Posted by "Torsten Dettborn (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PLUTO-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12505587 ] 

Torsten Dettborn commented on PLUTO-271:
----------------------------------------

The patch "PublicRenderParameter120607.patch " has been committed. The new revision number is 546468.

> patch for Shared-Render-Parameter
> ---------------------------------
>
>                 Key: PLUTO-271
>                 URL: https://issues.apache.org/jira/browse/PLUTO-271
>             Project: Pluto
>          Issue Type: New Feature
>          Components: general
>    Affects Versions: 1.1-286-COMPATIBILITY
>            Reporter: Torsten Dettborn
>             Fix For: 1.1-286-COMPATIBILITY
>
>         Attachments: public_render_parameters.action_exposure.140607.patch, PublicRenderParameter120607.patch, sharedRenderParameter.291106.patch
>
>
> This is a the new functionality for shared-render-parameter. You can see the description in the Specification in PLT. 14.2.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PLUTO-271) patch for public-render-parameter

Posted by "Torsten Dettborn (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PLUTO-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520981 ] 

Torsten Dettborn commented on PLUTO-271:
----------------------------------------

The patch  jaxb_public_render_add_qname_name_and_alias.190807.patch has committed, the new svn revision Number is 567468.

> patch for public-render-parameter
> ---------------------------------
>
>                 Key: PLUTO-271
>                 URL: https://issues.apache.org/jira/browse/PLUTO-271
>             Project: Pluto
>          Issue Type: New Feature
>          Components: general
>    Affects Versions: 1.1-286-COMPATIBILITY
>            Reporter: Torsten Dettborn
>             Fix For: 1.1-286-COMPATIBILITY
>
>         Attachments: jaxb_public_render_add_qname_name_and_alias.190807.patch, public_render_parameters.action_exposure.140607.patch, PublicRenderParameter120607.patch, sharedRenderParameter.291106.patch
>
>
> This is a the new functionality for public-render-parameter. You can see the description in the Specification in PLT. 14.2.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (PLUTO-271) patch for Shared-Render-Parameter

Posted by "Craig Doremus (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/PLUTO-271?page=all ]

Craig Doremus closed PLUTO-271.
-------------------------------

    Resolution: Fixed

Applied in revision 486942. Thank you Torsten!

> patch for Shared-Render-Parameter
> ---------------------------------
>
>                 Key: PLUTO-271
>                 URL: http://issues.apache.org/jira/browse/PLUTO-271
>             Project: Pluto
>          Issue Type: New Feature
>          Components: general
>    Affects Versions: 1.1-286-COMPATIBILITY
>            Reporter: Torsten Dettborn
>             Fix For: 1.1-286-COMPATIBILITY
>
>         Attachments: sharedRenderParameter.291106.patch
>
>
> This is a the new functionality for shared-render-parameter. You can see the description in the Specification in PLT. 14.2.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira