[GitHub] [geode] jchen21 commented on a change in pull request #6992: GEODE-9677: After provider sends ImageReply, requester could finish e…

[GitBox <gi...@apache.org>]

jchen21 commented on a change in pull request #6992:
URL: https://github.com/apache/geode/pull/6992#discussion_r728316600



##########
File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/GIIDeltaDUnitTest.java
##########
@@ -1530,8 +1530,8 @@ public String description() {
     // let GII continue
     P.invoke(() -> resetGIITestHook(DuringPackingImage, true));
     async3.join(MAX_WAIT * 2);
-    count = getDeltaGIICount(P);
-    assertEquals(0, count);
+    final int countConst = getDeltaGIICount(P);
+    GeodeAwaitility.await().untilAsserted(() -> assertEquals(0, countConst));

Review comment:
       Once `countConst` is assigned by `getDeltaGIICount(P)`, its value will not change. If its value is not `0`, no matter how long you wait, the assert in the next line still fails.
   I was thinking about `GeodeAwaitility.await().untilAsserted(() -> assertEquals(0, getDeltaGIICount(P)));`.
   Please correct me if I am wrong.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org