You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/02/10 08:03:35 UTC
Review Request 43413: CMake:[1/2] Allow downloading third-party
dependencies from mirror.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43413/
-----------------------------------------------------------
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Repository: mesos
Description
-------
CMake:[1/2] Allow downloading third-party dependencies from mirror.
Diffs
-----
3rdparty/CMakeLists.txt 3253da73aa517a335be94148d567510147dae08d
CMakeLists.txt 7f83dc84997d3b824d1f63012894bd9fc5284053
Diff: https://reviews.apache.org/r/43413/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 43413: CMake:[1/2] Allow downloading third-party
dependencies from mirror.
Posted by M Lawindi <ml...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43413/#review118909
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
CMakeLists.txt (line 48)
<https://reviews.apache.org/r/43413/#comment180219>
Make sure you trim this to 80 columns or less
- M Lawindi
On Feb. 10, 2016, 7:03 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43413/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 7:03 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake:[1/2] Allow downloading third-party dependencies from mirror.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 3253da73aa517a335be94148d567510147dae08d
> CMakeLists.txt 7f83dc84997d3b824d1f63012894bd9fc5284053
>
> Diff: https://reviews.apache.org/r/43413/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 43413: CMake:[1/2] Allow downloading third-party
dependencies from mirror.
Posted by Yi Sun <yi...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43413/#review119095
-----------------------------------------------------------
Ship it!
Ship It!
- Yi Sun
On Feb. 10, 2016, 7:03 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43413/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 7:03 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake:[1/2] Allow downloading third-party dependencies from mirror.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 3253da73aa517a335be94148d567510147dae08d
> CMakeLists.txt 7f83dc84997d3b824d1f63012894bd9fc5284053
>
> Diff: https://reviews.apache.org/r/43413/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 43413: CMake:[1/2] Allow downloading third-party
dependencies from mirror.
Posted by Alex Naparu <al...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43413/#review119931
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43413/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 12:59 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake:[1/2] Allow downloading third-party dependencies from mirror.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 3253da73aa517a335be94148d567510147dae08d
> CMakeLists.txt 7f83dc84997d3b824d1f63012894bd9fc5284053
>
> Diff: https://reviews.apache.org/r/43413/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 43413: CMake:[1/2] Allow downloading third-party
dependencies from mirror.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43413/#review121219
-----------------------------------------------------------
3rdparty/CMakeLists.txt (line 36)
<https://reviews.apache.org/r/43413/#comment182902>
Committed with `s/we us different/we use a different/`
- Michael Park
On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43413/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 12:59 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake:[1/2] Allow downloading third-party dependencies from mirror.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 3253da73aa517a335be94148d567510147dae08d
> CMakeLists.txt 7f83dc84997d3b824d1f63012894bd9fc5284053
>
> Diff: https://reviews.apache.org/r/43413/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 43413: CMake:[1/2] Allow downloading third-party
dependencies from mirror.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43413/
-----------------------------------------------------------
(Updated Feb. 18, 2016, 12:59 a.m.)
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Repository: mesos
Description
-------
CMake:[1/2] Allow downloading third-party dependencies from mirror.
Diffs (updated)
-----
3rdparty/CMakeLists.txt 3253da73aa517a335be94148d567510147dae08d
CMakeLists.txt 7f83dc84997d3b824d1f63012894bd9fc5284053
Diff: https://reviews.apache.org/r/43413/diff/
Testing
-------
Thanks,
Alex Clemmer