You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/01/17 13:27:26 UTC

[GitHub] [iotdb] wangchao316 commented on a change in pull request #4863: [IOTDB-2414][IOTDB-2419]Fix partial insert failure exception message && Fix three level aligned path query bug

wangchao316 commented on a change in pull request #4863:
URL: https://github.com/apache/iotdb/pull/4863#discussion_r786004896



##########
File path: server/src/main/java/org/apache/iotdb/db/qp/logical/crud/InsertOperator.java
##########
@@ -110,7 +110,7 @@ public PhysicalPlan generatePhysicalPlan(PhysicalGenerator generator)
                 measurementsNum, valueLists.get(i).length));
       }
       InsertRowPlan insertRowPlan =
-          new InsertRowPlan(device, times[i], measurementList, valueLists.get(i));
+          new InsertRowPlan(device, times[i], measurementList.clone(), valueLists.get(i));

Review comment:
       Does clone affect write performance?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org