You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/10/01 10:56:27 UTC

[GitHub] [submarine] xunliu commented on a change in pull request #422: SUBMARINE-641. Auto convert experiment name to lowercase

xunliu commented on a change in pull request #422:
URL: https://github.com/apache/submarine/pull/422#discussion_r498156531



##########
File path: submarine-server/server-core/src/main/java/org/apache/submarine/server/notebook/NotebookManager.java
##########
@@ -79,6 +79,8 @@ public static NotebookManager getInstance() {
    */
   public Notebook createNotebook(NotebookSpec spec) throws SubmarineRuntimeException {
     checkNotebookSpec(spec);
+    String lowerName = spec.getMeta().getName().toLowerCase();

Review comment:
       Does the `experiment name` need to be unified into lowercase?
   If necessary, it may be better to control case in the web front end.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org