You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by jf...@apache.org on 2019/05/04 18:35:43 UTC
[plc4x] 03/03: Bugfix in the Python code.
This is an automated email from the ASF dual-hosted git repository.
jfeinauer pushed a commit to branch feature/code-gen
in repository https://gitbox.apache.org/repos/asf/plc4x.git
commit 559078811e7c72c2d676cdf673d8f9e7782ddadb
Author: Julian Feinauer <j....@pragmaticminds.de>
AuthorDate: Sat May 4 20:35:28 2019 +0200
Bugfix in the Python code.
---
.../src/main/java/org/apache/plc4x/codegen/version2/PojoFactory.java | 2 +-
.../main/java/org/apache/plc4x/codegen/version2/PythonGenerator.java | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/sandbox/code-gen/src/main/java/org/apache/plc4x/codegen/version2/PojoFactory.java b/sandbox/code-gen/src/main/java/org/apache/plc4x/codegen/version2/PojoFactory.java
index 94de8f1..1042067 100644
--- a/sandbox/code-gen/src/main/java/org/apache/plc4x/codegen/version2/PojoFactory.java
+++ b/sandbox/code-gen/src/main/java/org/apache/plc4x/codegen/version2/PojoFactory.java
@@ -26,7 +26,7 @@ public class PojoFactory {
.collect(Collectors.toList());
- return new ClassDefinition("", desc.getName(), fields, null, getters, null);
+ return new ClassDefinition("", desc.getName(), fields, Arrays.asList(new ConstructorDeclaration(Collections.emptyList(), new Block())), getters, null);
}
public static class PojoDescription {
diff --git a/sandbox/code-gen/src/main/java/org/apache/plc4x/codegen/version2/PythonGenerator.java b/sandbox/code-gen/src/main/java/org/apache/plc4x/codegen/version2/PythonGenerator.java
index 70844e6..2e3d8f0 100644
--- a/sandbox/code-gen/src/main/java/org/apache/plc4x/codegen/version2/PythonGenerator.java
+++ b/sandbox/code-gen/src/main/java/org/apache/plc4x/codegen/version2/PythonGenerator.java
@@ -50,6 +50,9 @@ public class PythonGenerator implements Generator {
@Override public void writeBlock(Block statements) {
writer.startBlock();
+ if (statements.getStatements().isEmpty()) {
+ writer.writeLine("pass");
+ }
for (Node statement : statements.getStatements()) {
// Dont to the wrapping for If Statements
if (statement instanceof IfStatement) {
@@ -113,7 +116,6 @@ public class PythonGenerator implements Generator {
@Override public void generate(MethodDefinition methodDefinition) {
writer.startLine("def ");
- writer.write(" ");
writer.write(methodDefinition.getName());
writer.write("(");
for (int i = 0; i < methodDefinition.getParameters().size(); i++) {