You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by mp...@apache.org on 2016/09/09 04:40:03 UTC
[2/3] kudu git commit: ksck: add a note about spurious checksum
mismatches
ksck: add a note about spurious checksum mismatches
Safe-time isn't properly respected on the server side, which means that
running ksck in 'checksum' mode against an active table generates
spurious checksum mismatches. This just adds a note to that effect so
that users aren't confused.
Change-Id: I85babafb8d264be88dc71c9c878b53dae9c73901
Reviewed-on: http://gerrit.cloudera.org:8080/4341
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/814b0823
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/814b0823
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/814b0823
Branch: refs/heads/master
Commit: 814b08237b3e215bcb435cc19f5fbe0fe626f484
Parents: 45a970a
Author: Todd Lipcon <to...@apache.org>
Authored: Thu Sep 8 19:50:01 2016 -0700
Committer: Mike Percy <mp...@apache.org>
Committed: Fri Sep 9 04:39:30 2016 +0000
----------------------------------------------------------------------
src/kudu/tools/ksck.cc | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/814b0823/src/kudu/tools/ksck.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tools/ksck.cc b/src/kudu/tools/ksck.cc
index 7165280..270765d 100644
--- a/src/kudu/tools/ksck.cc
+++ b/src/kudu/tools/ksck.cc
@@ -536,7 +536,11 @@ Status Ksck::ChecksumData(const ChecksumOptions& opts) {
num_results, num_tablet_replicas);
if (num_mismatches != 0) {
- return Status::Corruption(Substitute("$0 checksum mismatches were detected", num_mismatches));
+ // TODO(KUDU-1020): remove the below note once safe time advancement is fully implemented.
+ return Status::Corruption(Substitute(
+ "$0 checksum mismatches were detected. "
+ "NOTE: if the table is actively being written to, this may generate spurious "
+ "checksum mismatches.", num_mismatches));
}
if (num_errors != 0) {
return Status::Aborted(Substitute("$0 errors were detected", num_errors));