You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2015/12/31 00:16:55 UTC
Review Request 41810: Added credential to Docker image protobuf.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41810/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
Repository: mesos
Description
-------
Added credential to Docker image protobuf.
Diffs
-----
include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6
Diff: https://reviews.apache.org/r/41810/diff/
Testing
-------
make
Thanks,
Timothy Chen
Re: Review Request 41810: Added credential to Docker image protobuf.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41810/#review113623
-----------------------------------------------------------
Should this also update `v1/mesos.proto`?
- Neil Conway
On Dec. 30, 2015, 11:16 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41810/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2015, 11:16 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added credential to Docker image protobuf.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6
>
> Diff: https://reviews.apache.org/r/41810/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 41810: Added credential to Docker image protobuf.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41810/#review112419
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Dec. 30, 2015, 3:16 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41810/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2015, 3:16 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added credential to Docker image protobuf.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6
>
> Diff: https://reviews.apache.org/r/41810/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 41810: Added credential to Docker image protobuf.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41810/#review113544
-----------------------------------------------------------
Ship it!
include/mesos/mesos.proto (line 1318)
<https://reviews.apache.org/r/41810/#comment174280>
Would you please mention that it's not encrypted. Operators should enable SSL to avoid leaking that information.
- Jie Yu
On Dec. 30, 2015, 11:16 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41810/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2015, 11:16 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added credential to Docker image protobuf.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6
>
> Diff: https://reviews.apache.org/r/41810/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Timothy Chen
>
>