You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by jk...@apache.org on 2006/11/23 17:54:16 UTC
svn commit: r478618 - in /tapestry/tapestry4/trunk:
tapestry-contrib/src/java/org/apache/tapestry/contrib/palette/Palette.script
tapestry-framework/src/java/org/apache/tapestry/html/Rollover.script
tapestry-framework/src/js/tapestry/widget/AlertDialog.js
Author: jkuhnert
Date: Thu Nov 23 08:54:13 2006
New Revision: 478618
URL: http://svn.apache.org/viewvc?view=rev&rev=478618
Log:
Fixed a couple easy low hanging fruit javascript related issues.
-) Alert dialog button didn't have a unique id and couldn't be tested with unit tests.
-) Rollover generated js wasn't compatible with async javascript evals()
-) Pallet.script was still using old deprecated Tapestry.onsubmit/onrefresh functions which caused
annoying dojo warning messages to be output.
Modified:
tapestry/tapestry4/trunk/tapestry-contrib/src/java/org/apache/tapestry/contrib/palette/Palette.script
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Rollover.script
tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/widget/AlertDialog.js
Modified: tapestry/tapestry4/trunk/tapestry-contrib/src/java/org/apache/tapestry/contrib/palette/Palette.script
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-contrib/src/java/org/apache/tapestry/contrib/palette/Palette.script?view=diff&rev=478618&r1=478617&r2=478618
==============================================================================
Binary files - no diff available.
Modified: tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Rollover.script
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Rollover.script?view=diff&rev=478618&r1=478617&r2=478618
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Rollover.script (original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Rollover.script Thu Nov 23 08:54:13 2006
@@ -56,12 +56,12 @@
{
if (document.images)
${attribute} = ${mouseOverImageURL};
-}
+};
tapestry.${onMouseOutName}=function()
{
if (document.images)
${attribute} = ${mouseOutImageURL};
-}
+};
</body>
</script>
Modified: tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/widget/AlertDialog.js
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/widget/AlertDialog.js?view=diff&rev=478618&r1=478617&r2=478618
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/widget/AlertDialog.js (original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/widget/AlertDialog.js Thu Nov 23 08:54:13 2006
@@ -49,6 +49,7 @@
var buttNode=document.createElement("button");
dojo.html.setClass(buttNode, this.buttonClass);
+ buttNode.setAttribute("id", "alertButton");
buttNode.innerHTML = "Ok";
content.appendChild(buttNode);