[GitHub] [flink] rkhachatryan commented on a diff in pull request #21833: [FLINK-30852][runtime] Checking task cancelation explicitly rather than failing the cancel method

["rkhachatryan (via GitHub)" <gi...@apache.org>]

rkhachatryan commented on code in PR #21833:
URL: https://github.com/apache/flink/pull/21833#discussion_r1163338534


##########
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java:
##########
@@ -1300,9 +1304,7 @@ public TestInvokableCorrect(Environment environment) {
         public void invoke() {}
 
         @Override
-        public void cancel() {
-            fail("This should not be called");

Review Comment:
   nit: although this won't cause test failure, I think logging (unexpected) cancellation makes debugging and reading the code a bit easier



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org