You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/11/30 17:45:00 UTC

[jira] [Commented] (PHOENIX-5728) Gold files for Phoenix test BaseStatsCollectorIT

    [ https://issues.apache.org/jira/browse/PHOENIX-5728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240917#comment-17240917 ] 

ASF GitHub Bot commented on PHOENIX-5728:
-----------------------------------------

virajjasani opened a new pull request #990:
URL: https://github.com/apache/phoenix/pull/990


   * ExplainPlan can provide plan as attributes object for simplified assertion of individual plan attributes
   * Provide an additional API to get plan object
   * Explain queries can still continue to provide output as String / list of String, object based approach is just an additional parameter for better comparison
   * Utilizes object based comparison in BaseStatsCollectorIT as per Jira, the plan is to extend object based comparison to maximum tests with further sub-tasks of [PHOENIX-5265](https://issues.apache.org/jira/browse/PHOENIX-5265)
   * Support HashJoinPlan as part of separate Jira


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Gold files for Phoenix test BaseStatsCollectorIT
> ------------------------------------------------
>
>                 Key: PHOENIX-5728
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5728
>             Project: Phoenix
>          Issue Type: Sub-task
>    Affects Versions: 5.1.0, 4.15.1
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Major
>             Fix For: 5.1.0, 4.16.1, 4.17.0
>
>         Attachments: PHOENIX-5728.master.000.patch, PHOENIX-5728.master.000.patch
>
>
> Provide golden files for QueryPlan result comparison for all abstract test class BaseStatsCollectorIT that includes tests of all stats collections including:
>  * NamespaceDisabledStatsCollectorIT
>  * NamespaceEnabledStatsCollectorIT
>  * NonTxStatsCollectorIT
>  * TxStatsCollectorIT



--
This message was sent by Atlassian Jira
(v8.3.4#803005)