[GitHub] [superset] ofekisr commented on a change in pull request #16991: fix(QueryContext): validation does not validate query_context metrics

[GitBox <gi...@apache.org>]

ofekisr commented on a change in pull request #16991:
URL: https://github.com/apache/superset/pull/16991#discussion_r732135955



##########
File path: superset/charts/api.py
##########
@@ -644,6 +646,11 @@ def get_data(self, pk: int) -> Response:
 
         return self.get_data_response(command, form_data=form_data)
 
+    def _create_chart_data_command(self) -> ChartDataCommand:
+        return ChartDataCommand(
+            QueryContextValidatorImpl(DatasetDAO(), security_manager)  # type: ignore

Review comment:
       Security manager is a local proxy not a real security manager 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org