You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/20 00:06:32 UTC
[GitHub] [superset] ktmud opened a new issue #13249: [Explore][Control] Allow selecting ad-hoc metrics in filters
ktmud opened a new issue #13249:
URL: https://github.com/apache/superset/issues/13249
When adhoc filters were first added ( #4909 ), it can select from selected adhoc metrics. Part of the code is also still there, but the feature somehow stopped working from certain point.
Could be related to #12095
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #13249: [Explore][Control] Allow selecting ad-hoc metrics in filters
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #13249:
URL: https://github.com/apache/superset/issues/13249#issuecomment-783126465
Thank you all for suggesting new features.
committed to both.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on issue #13249: [Explore][Control] Allow selecting ad-hoc metrics in filters
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #13249:
URL: https://github.com/apache/superset/issues/13249#issuecomment-782467135
I discovered this while working on #13221
Will take a look once more refactoring is done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #13249: [Explore][Control] Allow selecting ad-hoc metrics in filters
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #13249:
URL: https://github.com/apache/superset/issues/13249#issuecomment-782889659
@villebro @ktmud hey both, please take a look the draft 1 year roadmap for Explore and send me comments, thoughts before I finalize?
<img width="1510" alt="Screen Shot 2021-02-21 at 9 05 33 AM" src="https://user-images.githubusercontent.com/67837651/108632475-00714500-7424-11eb-8c09-ff8d39a33ec1.png">
<img width="1484" alt="Screen Shot 2021-02-21 at 9 03 08 AM" src="https://user-images.githubusercontent.com/67837651/108632439-ce5fe300-7423-11eb-949d-f4086ea861a7.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #13249: [Explore][Control] Allow selecting ad-hoc metrics in filters
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #13249:
URL: https://github.com/apache/superset/issues/13249#issuecomment-782889659
@villebro @ktmud hey both, please take a look the draft 1 year roadmap for Explore and send me comments, thoughts before I finalize? I believe I already captured everything requested by the community. shared the google sheet link with you, you can comment directly on it. 🙏
<img width="1510" alt="Screen Shot 2021-02-21 at 9 05 33 AM" src="https://user-images.githubusercontent.com/67837651/108632475-00714500-7424-11eb-8c09-ff8d39a33ec1.png">
<img width="1486" alt="Screen Shot 2021-02-21 at 9 38 31 AM" src="https://user-images.githubusercontent.com/67837651/108633337-97d89700-7428-11eb-8ef5-86c3cdcc21c6.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #13249: [Explore][Control] Allow selecting ad-hoc metrics in filters
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #13249:
URL: https://github.com/apache/superset/issues/13249#issuecomment-782889659
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #13249: [Explore][Control] Allow selecting ad-hoc metrics in filters
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #13249:
URL: https://github.com/apache/superset/issues/13249#issuecomment-782889659
@villebro @ktmud hey both, please take a look the draft 1 year roadmap for Explore and send me comments, thoughts before I finalize? I believe we captured most of the significant items requested by the community.
shared a gsheet link with you, please comment directly on it. 🙏
<img width="1509" alt="Screen Shot 2021-02-21 at 10 23 33 AM" src="https://user-images.githubusercontent.com/67837651/108634560-f4d74b80-742e-11eb-9846-3c53613af3df.png">
<img width="1484" alt="Screen Shot 2021-02-21 at 10 23 51 AM" src="https://user-images.githubusercontent.com/67837651/108634562-f6a10f00-742e-11eb-920a-be697978b8ee.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on issue #13249: [Explore][Control] Allow selecting ad-hoc metrics in filters
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #13249:
URL: https://github.com/apache/superset/issues/13249#issuecomment-782829736
Two feature requests I've been thinking on for a while:
1. **Adhoc Column:** similar to adhoc metrics, users should also be able to create adhoc calculated columns (dimensions)
2. **Adhoc metric/column in other controls:** users should be able to select already created adhoc metrics and columns in other controls (e.g. sort by and filters).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #13249: [Explore][Control] Allow selecting ad-hoc metrics in filters
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #13249:
URL: https://github.com/apache/superset/issues/13249#issuecomment-782889659
@villebro @ktmud hey both, please take a look the draft 1 year roadmap for Explore and send me comments, thoughts before I finalize? I believe I already captured everything requested by the community. shared the google sheet link with you, you can comment directly. 🙏 the sooner you both can provide feedback, the sooner we can open to the public.
<img width="1510" alt="Screen Shot 2021-02-21 at 9 05 33 AM" src="https://user-images.githubusercontent.com/67837651/108632475-00714500-7424-11eb-8c09-ff8d39a33ec1.png">
<img width="1484" alt="Screen Shot 2021-02-21 at 9 03 08 AM" src="https://user-images.githubusercontent.com/67837651/108632439-ce5fe300-7423-11eb-949d-f4086ea861a7.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #13249: [Explore][Control] Allow selecting ad-hoc metrics in filters
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #13249:
URL: https://github.com/apache/superset/issues/13249#issuecomment-782889659
@villebro @ktmud take a look the draft 1 year roadmap for Explore.send me comments, thoughts before I finalize?
<img width="1510" alt="Screen Shot 2021-02-21 at 9 02 11 AM" src="https://user-images.githubusercontent.com/67837651/108632430-c142f400-7423-11eb-878b-034e4c46c0e9.png">
<img width="1484" alt="Screen Shot 2021-02-21 at 9 03 08 AM" src="https://user-images.githubusercontent.com/67837651/108632439-ce5fe300-7423-11eb-949d-f4086ea861a7.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #13249: [Explore][Control] Allow selecting ad-hoc metrics in filters
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #13249:
URL: https://github.com/apache/superset/issues/13249#issuecomment-782512032
> Will take a look once more refactoring is done.
happy to take it on while we are refractor the filter component in a few weeks. @ktmud
@zuzana-vej can you provide a complete list of expected behavior in ad hoc filter and metric popover, + new features suggestion (i.e, in-place saving metric)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie edited a comment on issue #13249: [Explore][Control] Allow selecting ad-hoc metrics in filters
Posted by GitBox <gi...@apache.org>.
zhaoyongjie edited a comment on issue #13249:
URL: https://github.com/apache/superset/issues/13249#issuecomment-783125325
> Two feature requests I've been thinking on for a while:
>
> 1. **Adhoc Column:** similar to adhoc metrics, users should also be able to create adhoc calculated columns (dimensions)
>
> 2. **Adhoc metric/column in other controls:** users should be able to select already created adhoc metrics and columns in other controls (e.g. sort by and filters).
I'm trying to redesign the semantic layer, it might help. these are good requests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #13249: [Explore][Control] Allow selecting ad-hoc metrics in filters
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #13249:
URL: https://github.com/apache/superset/issues/13249#issuecomment-782889659
@villebro @ktmud hey both, please take a look the draft 1 year roadmap for Explore and send me comments, thoughts before I finalize? I share the google sheet link with you, you can comment directly. 🙏
<img width="1510" alt="Screen Shot 2021-02-21 at 9 05 33 AM" src="https://user-images.githubusercontent.com/67837651/108632475-00714500-7424-11eb-8c09-ff8d39a33ec1.png">
<img width="1484" alt="Screen Shot 2021-02-21 at 9 03 08 AM" src="https://user-images.githubusercontent.com/67837651/108632439-ce5fe300-7423-11eb-949d-f4086ea861a7.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on issue #13249: [Explore][Control] Allow selecting ad-hoc metrics in filters
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on issue #13249:
URL: https://github.com/apache/superset/issues/13249#issuecomment-783125325
> Two feature requests I've been thinking on for a while:
>
> 1. **Adhoc Column:** similar to adhoc metrics, users should also be able to create adhoc calculated columns (dimensions)
>
> 2. **Adhoc metric/column in other controls:** users should be able to select already created adhoc metrics and columns in other controls (e.g. sort by and filters).
I'm trying to redesign the semantic layer, it might help. these are a good request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie edited a comment on issue #13249: [Explore][Control] Allow selecting ad-hoc metrics in filters
Posted by GitBox <gi...@apache.org>.
zhaoyongjie edited a comment on issue #13249:
URL: https://github.com/apache/superset/issues/13249#issuecomment-783125325
> Two feature requests I've been thinking on for a while:
>
> 1. **Adhoc Column:** similar to adhoc metrics, users should also be able to create adhoc calculated columns (dimensions)
>
> 2. **Adhoc metric/column in other controls:** users should be able to select already created adhoc metrics and columns in other controls (e.g. sort by and filters).
I'm trying to redesign the semantic layer, it might help. these are good request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on issue #13249: [Explore][Control] Allow selecting ad-hoc metrics in filters
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #13249:
URL: https://github.com/apache/superset/issues/13249#issuecomment-782835310
> Two feature requests I've been thinking on for a while:
>
>
>
> 1. **Adhoc Column:** similar to adhoc metrics, users should also be able to create adhoc calculated columns (dimensions)
>
> 2. **Adhoc metric/column in other controls:** users should be able to select already created adhoc metrics and columns in other controls (e.g. sort by and filters).
Big +1 for adhoc columns!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org