You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/15 17:35:49 UTC
[GitHub] [kafka] wcarlson5 opened a new pull request #10543: KAFKA-12648: tag uses of StreamsException to add Named to
wcarlson5 opened a new pull request #10543:
URL: https://github.com/apache/kafka/pull/10543
change each StreamsException so that it has the sub topology name in it
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wcarlson5 closed pull request #10543: KAFKA-12648: tag uses of StreamsException to add Named to
Posted by GitBox <gi...@apache.org>.
wcarlson5 closed pull request #10543:
URL: https://github.com/apache/kafka/pull/10543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10543: KAFKA-12648: tag uses of StreamsException to add Named to
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10543:
URL: https://github.com/apache/kafka/pull/10543#issuecomment-823549804
Thanks for the draft -- I haven't looked through it in detail but I think I got the gist of it. One thing I’m wondering is whether we need to track down and update each and every individual source of a StreamsException, which is a long list that will only grow over time, or if it would be easier to just catch and wrap/convert these StreamsExceptions at the highest level in which you can still distinguish the source task. I worry that doing it at the lowest level like this is too prone to things slipping through: even if we gathered every single source exception now, new PRs will add new causes of exception and we can't rely on every single person knowing, and remembering, to incorporate this new feature.
Plus, it'll be somewhat unmanageable to percolate this NamedTopology information everywhere throughout Streams. If we can find a way to keep it isolated to a few top-level classes then I think we'll be in better shape, and much more future proof. Let's discuss it during the sync today but I'm thinking the only classes who probably need to know about any of this are StreamThread, TaskManager, StreamsPartitionAssignor, etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wcarlson5 commented on pull request #10543: KAFKA-12648: tag uses of StreamsException to add Named to
Posted by GitBox <gi...@apache.org>.
wcarlson5 commented on pull request #10543:
URL: https://github.com/apache/kafka/pull/10543#issuecomment-823594600
https://github.com/apache/kafka/pull/10544 I have a draft for the other part as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wcarlson5 commented on pull request #10543: KAFKA-12648: tag uses of StreamsException to add Named to
Posted by GitBox <gi...@apache.org>.
wcarlson5 commented on pull request #10543:
URL: https://github.com/apache/kafka/pull/10543#issuecomment-820610403
@ableegoldman I tagged all the cases of StreamsExceptions that I think can be attributed to a Sub topology. I may have missed some and some might not be attributable. Also there might be other error types so I am relying on all exceptions being wrapped in a streamsException before they reach the handler. However I know I have seen one thing in soak where that is not the case. But it is a start
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org