You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/08/04 14:34:54 UTC
[GitHub] [incubator-yunikorn-core] adamantal opened a new pull request #195: [YUNIKORN-343] Provide a placement rule that can support attaching NSs to parent queue
adamantal opened a new pull request #195:
URL: https://github.com/apache/incubator-yunikorn-core/pull/195
I uploaded this preliminary implementation - not yet ready for review.
I will also add a documentation patch parallel to this PR which can be merged as well.
Will add UT to cover the new behaviour.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] TravisBuddy commented on pull request #195: [YUNIKORN-343] Provide a placement rule that can support attaching NSs to parent queue
Posted by GitBox <gi...@apache.org>.
TravisBuddy commented on pull request #195:
URL: https://github.com/apache/incubator-yunikorn-core/pull/195#issuecomment-669286908
Hey @adamantal,
Your changes look good to me!
<a href="https://travis-ci.org/apache/incubator-yunikorn-core/builds/715163579">View build log</a>
###### TravisBuddy Request Identifier: 804bd280-d736-11ea-85fc-4b61cecd2c91
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] adamantal commented on pull request #195: [YUNIKORN-343] Provide a placement rule that can support attaching NSs to parent queue
Posted by GitBox <gi...@apache.org>.
adamantal commented on pull request #195:
URL: https://github.com/apache/incubator-yunikorn-core/pull/195#issuecomment-669235299
Added documentation in https://github.com/apache/incubator-yunikorn-site/pull/13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s commented on pull request #195: [YUNIKORN-343] Provide a placement rule that can support attaching NSs to parent queue
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #195:
URL: https://github.com/apache/incubator-yunikorn-core/pull/195#issuecomment-680872289
Closing as the approach is now to use the existing tag rules per YUNIKORN-368
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s closed pull request #195: [YUNIKORN-343] Provide a placement rule that can support attaching NSs to parent queue
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #195:
URL: https://github.com/apache/incubator-yunikorn-core/pull/195
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #195: [YUNIKORN-343] Provide a placement rule that can support attaching NSs to parent queue
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #195:
URL: https://github.com/apache/incubator-yunikorn-core/pull/195#issuecomment-669212824
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=h1) Report
> Merging [#195](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/357d71fa290619e583b5da0484215c5d927807b7&el=desc) will **decrease** coverage by `0.43%`.
> The diff coverage is `19.04%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
- Coverage 60.08% 59.64% -0.44%
==========================================
Files 67 68 +1
Lines 6468 6500 +32
==========================================
- Hits 3886 3877 -9
- Misses 2441 2491 +50
+ Partials 141 132 -9
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/placement/mapping\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvbWFwcGluZ19ydWxlLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/scheduler/placement/fixed\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvZml4ZWRfcnVsZS5nbw==) | `68.42% <50.00%> (+5.15%)` | :arrow_up: |
| [pkg/scheduler/placement/provided\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvcHJvdmlkZWRfcnVsZS5nbw==) | `78.78% <50.00%> (+8.33%)` | :arrow_up: |
| [pkg/scheduler/placement/user\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvdXNlcl9ydWxlLmdv) | `76.66% <50.00%> (+8.37%)` | :arrow_up: |
| [pkg/scheduler/placement/rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvcnVsZS5nbw==) | `79.59% <57.89%> (-13.75%)` | :arrow_down: |
| [pkg/scheduler/placement/tag\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvdGFnX3J1bGUuZ28=) | `84.21% <100.00%> (+8.70%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=footer). Last update [357d71f...f751368](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #195: [YUNIKORN-343] Provide a placement rule that can support attaching NSs to parent queue
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #195:
URL: https://github.com/apache/incubator-yunikorn-core/pull/195#issuecomment-669212824
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=h1) Report
> Merging [#195](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/357d71fa290619e583b5da0484215c5d927807b7&el=desc) will **increase** coverage by `0.46%`.
> The diff coverage is `85.88%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
+ Coverage 60.08% 60.54% +0.46%
==========================================
Files 67 68 +1
Lines 6468 6501 +33
==========================================
+ Hits 3886 3936 +50
+ Misses 2441 2433 -8
+ Partials 141 132 -9
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/placement/fixed\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvZml4ZWRfcnVsZS5nbw==) | `73.68% <50.00%> (+10.41%)` | :arrow_up: |
| [pkg/scheduler/placement/provided\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvcHJvdmlkZWRfcnVsZS5nbw==) | `78.78% <50.00%> (+8.33%)` | :arrow_up: |
| [pkg/scheduler/placement/user\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvdXNlcl9ydWxlLmdv) | `76.66% <50.00%> (+8.37%)` | :arrow_up: |
| [pkg/scheduler/placement/rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvcnVsZS5nbw==) | `83.67% <68.42%> (-9.66%)` | :arrow_down: |
| [pkg/scheduler/placement/mapping\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvbWFwcGluZ19ydWxlLmdv) | `94.82% <94.82%> (ø)` | |
| [pkg/scheduler/placement/tag\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvdGFnX3J1bGUuZ28=) | `84.21% <100.00%> (+8.70%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=footer). Last update [357d71f...f751368](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] commented on pull request #195: [YUNIKORN-343] Provide a placement rule that can support attaching NSs to parent queue
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #195:
URL: https://github.com/apache/incubator-yunikorn-core/pull/195#issuecomment-669212824
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=h1) Report
> Merging [#195](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/357d71fa290619e583b5da0484215c5d927807b7&el=desc) will **decrease** coverage by `0.43%`.
> The diff coverage is `19.04%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
- Coverage 60.08% 59.64% -0.44%
==========================================
Files 67 68 +1
Lines 6468 6500 +32
==========================================
- Hits 3886 3877 -9
- Misses 2441 2491 +50
+ Partials 141 132 -9
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/placement/mapping\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvbWFwcGluZ19ydWxlLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/scheduler/placement/fixed\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvZml4ZWRfcnVsZS5nbw==) | `68.42% <50.00%> (+5.15%)` | :arrow_up: |
| [pkg/scheduler/placement/provided\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvcHJvdmlkZWRfcnVsZS5nbw==) | `78.78% <50.00%> (+8.33%)` | :arrow_up: |
| [pkg/scheduler/placement/user\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvdXNlcl9ydWxlLmdv) | `76.66% <50.00%> (+8.37%)` | :arrow_up: |
| [pkg/scheduler/placement/rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvcnVsZS5nbw==) | `79.59% <57.89%> (-13.75%)` | :arrow_down: |
| [pkg/scheduler/placement/tag\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvdGFnX3J1bGUuZ28=) | `84.21% <100.00%> (+8.70%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=footer). Last update [357d71f...1d1b35d](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] TravisBuddy commented on pull request #195: [YUNIKORN-343] Provide a placement rule that can support attaching NSs to parent queue
Posted by GitBox <gi...@apache.org>.
TravisBuddy commented on pull request #195:
URL: https://github.com/apache/incubator-yunikorn-core/pull/195#issuecomment-668635786
Hey @adamantal,
Your changes look good to me!
<a href="https://travis-ci.org/apache/incubator-yunikorn-core/builds/714831859">View build log</a>
###### TravisBuddy Request Identifier: 29e799f0-d660-11ea-8693-3322afd57804
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org