You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alinaliBQ (via GitHub)" <gi...@apache.org> on 2026/01/10 00:23:41 UTC
[PR] MINOR: [C++][FlightRPC] ODBC: Add missing `arrow::` to fix build [arrow]
alinaliBQ opened a new pull request, #48810:
URL: https://github.com/apache/arrow/pull/48810
### Rationale for this change
Add `arrow::` to `Decimal128Type::kMaxPrecision` to fix the build
### What changes are included in this PR?
- Add `arrow::` as prefix to `Decimal128Type::kMaxPrecision`
### Are these changes tested?
- Yes, on local MSVC
### Are there any user-facing changes?
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48811: [C++][FlightRPC] ODBC: Add missing `arrow::` to fix build [arrow]
Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on PR #48810:
URL: https://github.com/apache/arrow/pull/48810#issuecomment-3731177360
> Oh BTW I believe this needs a ticket instead of marking it [a minor](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#minor-fixes)
Thanks for the reminder, I have raise an issue https://github.com/apache/arrow/issues/48811 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++][FlightRPC] ODBC: Add missing `arrow::` to fix build [arrow]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #48810:
URL: https://github.com/apache/arrow/pull/48810#issuecomment-3731155374
Oh BTW I believe this needs a ticket instead of marking it [a minor](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#minor-fixes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48811: [C++][FlightRPC] ODBC: Add missing `arrow::` to fix build [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #48810:
URL: https://github.com/apache/arrow/pull/48810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++][FlightRPC] ODBC: Add missing `arrow::` to fix build [arrow]
Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on PR #48810:
URL: https://github.com/apache/arrow/pull/48810#issuecomment-3731129866
Hi @lidavidm could you take a look at this minor PR? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48811: [C++][FlightRPC] ODBC: Add missing `arrow::` to fix build [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #48810:
URL: https://github.com/apache/arrow/pull/48810#issuecomment-3731177073
:warning: GitHub issue #48811 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48811: [C++][FlightRPC] ODBC: Add missing `arrow::` to fix build [arrow]
Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on PR #48810:
URL: https://github.com/apache/arrow/pull/48810#issuecomment-3731178437
> LGTM thanks for catching this. I think I shouldn't touch this code path till my env is fully ready 😅
No worries! Ty for taking a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48811: [C++][FlightRPC] ODBC: Add missing `arrow::` to fix build [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #48810:
URL: https://github.com/apache/arrow/pull/48810#issuecomment-3732731654
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 6c7de4ee6baeb9d47dff9aa9f8bfe41ef251a7cf.
There weren't enough matching historic benchmark results to make a call on whether there were regressions.
The [full Conbench report](https://github.com/apache/arrow/runs/59992265547) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org