You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/01/14 04:11:10 UTC
[GitHub] [shardingsphere] menghaoranss opened a new pull request #9022: Refactor SchemaChangedListener
menghaoranss opened a new pull request #9022:
URL: https://github.com/apache/shardingsphere/pull/9022
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Lucas-307 merged pull request #9022: Refactor SchemaChangedListener
Posted by GitBox <gi...@apache.org>.
Lucas-307 merged pull request #9022:
URL: https://github.com/apache/shardingsphere/pull/9022
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #9022: Refactor SchemaChangedListener
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9022:
URL: https://github.com/apache/shardingsphere/pull/9022#issuecomment-759938061
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9022?src=pr&el=h1) Report
> Merging [#9022](https://codecov.io/gh/apache/shardingsphere/pull/9022?src=pr&el=desc) (a1d9e80) into [master](https://codecov.io/gh/apache/shardingsphere/commit/1e08a02c75ba527840fce825d035295ba612f970?el=desc) (1e08a02) will **decrease** coverage by `0.04%`.
> The diff coverage is `43.33%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/9022/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/9022?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9022 +/- ##
============================================
- Coverage 70.20% 70.15% -0.05%
- Complexity 655 658 +3
============================================
Files 1635 1635
Lines 26319 26347 +28
Branches 4589 4595 +6
============================================
+ Hits 18476 18483 +7
- Misses 6583 6601 +18
- Partials 1260 1263 +3
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/9022?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...phere/governance/core/config/ConfigCenterNode.java](https://codecov.io/gh/apache/shardingsphere/pull/9022/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9jb25maWcvQ29uZmlnQ2VudGVyTm9kZS5qYXZh) | `52.77% <6.25%> (-38.14%)` | `0.00 <0.00> (ø)` | |
| [...pository/zookeeper/CuratorZookeeperRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/9022/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLXJlcG9zaXRvcnkvc2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS1yZXBvc2l0b3J5LXByb3ZpZGVyL3NoYXJkaW5nc3BoZXJlLWdvdmVybmFuY2UtcmVwb3NpdG9yeS16b29rZWVwZXItY3VyYXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZ292ZXJuYW5jZS9yZXBvc2l0b3J5L3pvb2tlZXBlci9DdXJhdG9yWm9va2VlcGVyUmVwb3NpdG9yeS5qYXZh) | `72.05% <71.42%> (-0.04%)` | `31.00 <3.00> (+3.00)` | :arrow_down: |
| [...ingsphere/governance/core/config/ConfigCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/9022/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9jb25maWcvQ29uZmlnQ2VudGVyLmphdmE=) | `79.48% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ce/core/config/listener/SchemaChangedListener.java](https://codecov.io/gh/apache/shardingsphere/pull/9022/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9jb25maWcvbGlzdGVuZXIvU2NoZW1hQ2hhbmdlZExpc3RlbmVyLmphdmE=) | `81.48% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...rdl/impl/CreateReplicaQueryRuleBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/9022/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL2ltcGwvQ3JlYXRlUmVwbGljYVF1ZXJ5UnVsZUJhY2tlbmRIYW5kbGVyLmphdmE=) | `84.61% <0.00%> (-15.39%)` | `1.00% <0.00%> (ø%)` | |
| [...re/proxy/frontend/mysql/MySQLErrPacketFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/9022/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL015U1FMRXJyUGFja2V0RmFjdG9yeS5qYXZh) | `77.27% <0.00%> (-3.68%)` | `0.00% <0.00%> (ø%)` | |
| [...rdingsphere/db/protocol/error/CommonErrorCode.java](https://codecov.io/gh/apache/shardingsphere/pull/9022/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvZXJyb3IvQ29tbW9uRXJyb3JDb2RlLmphdmE=) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9022?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9022?src=pr&el=footer). Last update [1e08a02...a1d9e80](https://codecov.io/gh/apache/shardingsphere/pull/9022?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org