You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Chris Hostetter <ho...@fucit.org> on 2010/10/15 23:37:29 UTC

Re: svn commit: r1022335 - /lucene/dev/trunk/solr/src/test/org/apache/solr/BaseDistributedSearchTestC ase.java

: I don't think we should do this.
: 
: because the hudson jail has 'tcp blackhole' set, tests should *never*
: depend on connecting to a port not accepting connections and getting
: an RST (it won't happen).

How should we deal with tests where the entire point of hte code being 
tested is dealing with failure to connect?


-Hoss

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: svn commit: r1022335 - /lucene/dev/trunk/solr/src/test/org/apache/solr/BaseDistributedSearchTestC ase.java

Posted by Robert Muir <rc...@gmail.com>.
On Fri, Oct 15, 2010 at 5:37 PM, Chris Hostetter
<ho...@fucit.org> wrote:

> How should we deal with tests where the entire point of hte code being
> tested is dealing with failure to connect?
>
>

even disregarding the blackhole thing, this way is just wrong. what if
there happens to be a solr on port 33331?

lucene's contrib/remote had similar code, and when it randomly failed
because i had stuff running on the port it picked like that, i rewrote
that crap.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org