You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/05 21:51:04 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3944:
vpc/server: Fix network statistics for vpc
ustcweizhou opened a new pull request #3944: vpc/server: Fix network statistics for vpc
URL: https://github.com/apache/cloudstack/pull/3944
# Description
<!--- Describe your changes in detail -->
This contains 3 main changes
(1) add NETWORK_STATS_ethX for all nics with public ips in VPC VRs (current: NETWORK_STATS_eth1)
(2) DO NOT create records in user_statistics for each VPC tier (only one record per public nic per VPC VR)
(3) send NetworkUsageCommand before unplugging a NIC with public IPs from VPC VR
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3944: vpc/server: Fix
network statistics for vpc
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3944: vpc/server: Fix network statistics for vpc
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-595656380
> > Is this in progress or ready for review @ustcweizhou ?
>
> @rhtyd it is ready for review
>
> travis failed, I will check it.
don't bother @weizhouapache those seem to be the usual log too long errors. Travis stops at 4GB or so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3944: vpc/server:
Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3944: vpc/server: Fix network statistics for vpc
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-595676935
> > > Is this in progress or ready for review @ustcweizhou ?
> >
> >
> > @rhtyd it is ready for review
> > travis failed, I will check it.
>
> don't bother @weizhouapache those seem to be the usual log too long errors. Travis stops at 4GB or so.
thanks @DaanHoogland for your info.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3944: vpc/server:
Fix network statistics for vpc
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3944: vpc/server: Fix network statistics for vpc
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-595649725
> Is this in progress or ready for review @ustcweizhou ?
@rhtyd it is ready for review
travis failed, I will check it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3944: vpc/server: Fix
network statistics for vpc
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3944: vpc/server: Fix network statistics for vpc
URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-595622083
Is this in progress or ready for review @ustcweizhou ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services