You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by ka...@apache.org on 2025/09/18 15:59:00 UTC

(airflow) 03/08: fix(hitl): fix missing responded_user rename (#55777)

This is an automated email from the ASF dual-hosted git repository.

kaxilnaik pushed a commit to branch v3-1-test
in repository https://gitbox.apache.org/repos/asf/airflow.git

commit e88a9268c07aa8923f73eecb263cf85c25147bd8
Author: Wei Lee <we...@gmail.com>
AuthorDate: Thu Sep 18 18:19:29 2025 +0800

    fix(hitl): fix missing responded_user rename (#55777)
    
    (cherry picked from commit 14920608844f34bfd1407ffc13de8dabf9d8f6ce)
---
 .../src/airflow/api_fastapi/core_api/routes/public/hitl.py     | 10 ++++++----
 .../tests/unit/api_fastapi/core_api/routes/public/test_hitl.py |  4 ++--
 providers/standard/tests/unit/standard/triggers/test_hitl.py   |  3 +--
 3 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/airflow-core/src/airflow/api_fastapi/core_api/routes/public/hitl.py b/airflow-core/src/airflow/api_fastapi/core_api/routes/public/hitl.py
index 7aa430ae630..d8635c70343 100644
--- a/airflow-core/src/airflow/api_fastapi/core_api/routes/public/hitl.py
+++ b/airflow-core/src/airflow/api_fastapi/core_api/routes/public/hitl.py
@@ -213,6 +213,8 @@ def get_hitl_details(
                     "subject",
                     "responded_at",
                     "created_at",
+                    "responded_by_user_id",
+                    "responded_by_user_name",
                 ],
                 model=HITLDetailModel,
                 to_replace={
@@ -237,8 +239,8 @@ def get_hitl_details(
     ti_state: QueryTIStateFilter,
     # hitl detail related filter
     response_received: QueryHITLDetailResponseReceivedFilter,
-    responded_user_id: QueryHITLDetailRespondedUserIdFilter,
-    responded_user_name: QueryHITLDetailRespondedUserNameFilter,
+    responded_by_user_id: QueryHITLDetailRespondedUserIdFilter,
+    responded_by_user_name: QueryHITLDetailRespondedUserNameFilter,
     subject_patten: QueryHITLDetailSubjectSearch,
     body_patten: QueryHITLDetailBodySearch,
     created_at: Annotated[RangeFilter, Depends(datetime_range_filter_factory("created_at", HITLDetailModel))],
@@ -271,8 +273,8 @@ def get_hitl_details(
             ti_state,
             # hitl detail related filter
             response_received,
-            responded_user_id,
-            responded_user_name,
+            responded_by_user_id,
+            responded_by_user_name,
             subject_patten,
             body_patten,
             created_at,
diff --git a/airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_hitl.py b/airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_hitl.py
index 22371bf1c25..161e81607d4 100644
--- a/airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_hitl.py
+++ b/airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_hitl.py
@@ -582,8 +582,8 @@ class TestGetHITLDetailsEndpoint:
             "body",
             "response_not_received",
             "response_received",
-            "responded_user_id",
-            "responded_user_name",
+            "responded_by_user_id",
+            "responded_by_user_name",
             "created_at_gte",
             "created_at_lte",
             "created_at",
diff --git a/providers/standard/tests/unit/standard/triggers/test_hitl.py b/providers/standard/tests/unit/standard/triggers/test_hitl.py
index 6aba3b1c60d..1441d04bfc0 100644
--- a/providers/standard/tests/unit/standard/triggers/test_hitl.py
+++ b/providers/standard/tests/unit/standard/triggers/test_hitl.py
@@ -79,8 +79,7 @@ class TestHITLTrigger:
         )
         mock_supervisor_comms.send.return_value = HITLDetailResponse(
             response_received=False,
-            responded_user_id=None,
-            responded_user_name=None,
+            responded_by_user=None,
             responded_at=None,
             chosen_options=None,
             params_input={},