[GitHub] [superset] betodealmeida commented on issue #22862: [SIP] Proposal for Catalog Support in SQL Lab

["betodealmeida (via GitHub)" <gi...@apache.org>]

betodealmeida commented on issue #22862:
URL: https://github.com/apache/superset/issues/22862#issuecomment-1404421324

   I would love to see this, but there are few complications. The biggest one is that we need support from the SQL Alchemy dialects, and I'm not sure how many support dynamic catalogs. For example, both Hive and Trino require the catalog to be specified when the connection is created:
   
   - `trino://<username>:<password>@<host>:<port>/<catalog>/<schema>`
   - `hive://<host>:<port>/<catalog>`
   
   For engines like this the user would have to choose a default catalog when the database is added, and each DB engine spec in Superset would have to know how to replace the catalog in the URL, in case a user chooses one different from the default after the DB has been created.
   
   It's definitely doable, and something we should do. We've been slowly adding support for catalogs:
   
   https://github.com/apache/superset/blob/383313b105b0e82bea0f38cc971630eded5affe0/superset/sql_parse.py#L172
   
   Are you planning to work on this, or are you just proposing it? If you're not going to work on it I can start taking a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org