You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "capistrant (via GitHub)" <gi...@apache.org> on 2026/10/09 03:13:07 UTC
[PR] fix: use provider that is called at query time instead of constructor (druid)
capistrant opened a new pull request, #20537:
URL: https://github.com/apache/druid/pull/20537
fixes a latent bug in #20508 where eagerly setting up the discovery provider at construction time could result in a guice error. Using the provider at query time should be ok I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] fix: use provider that is called at query time instead of constructor (druid)
Posted by "capistrant (via GitHub)" <gi...@apache.org>.
capistrant commented on code in PR #20537:
URL: https://github.com/apache/druid/pull/20537#discussion_r4272494512
##########
multi-stage-query/src/main/java/org/apache/druid/msq/dart/controller/DartControllerContextFactoryImpl.java:
##########
@@ -56,7 +55,7 @@ public class DartControllerContextFactoryImpl implements DartControllerContextFa
protected final MemoryIntrospector memoryIntrospector;
protected final List<InputSpecSlicerProvider> inputSpecSlicerProviders;
protected final ServiceEmitter emitter;
- protected final DruidNodeDiscovery dartWorkerDiscovery;
Review Comment:
Looking into this as a follow up improvement, thank you for suggesting!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] fix: use provider that is called at query time instead of constructor (druid)
Posted by "kgyrtkirk (via GitHub)" <gi...@apache.org>.
kgyrtkirk commented on code in PR #20537:
URL: https://github.com/apache/druid/pull/20537#discussion_r4227572753
##########
multi-stage-query/src/main/java/org/apache/druid/msq/dart/controller/DartControllerContextFactoryImpl.java:
##########
@@ -56,7 +55,7 @@ public class DartControllerContextFactoryImpl implements DartControllerContextFa
protected final MemoryIntrospector memoryIntrospector;
protected final List<InputSpecSlicerProvider> inputSpecSlicerProviders;
protected final ServiceEmitter emitter;
- protected final DruidNodeDiscovery dartWorkerDiscovery;
Review Comment:
note: I think it might worth a try to add an annotated `DruidNodeDiscovery` similar to `@Dart` ; and declare a method do produce that in a guice module... and depend on that
that way guice will see that factorization happening and could plan it into the construction timeline of this object (or error out with some reasoning )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] fix: use provider that is called at query time instead of constructor (druid)
Posted by "capistrant (via GitHub)" <gi...@apache.org>.
capistrant merged PR #20537:
URL: https://github.com/apache/druid/pull/20537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org