You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by "Alejandro Vilar (JIRA)" <ji...@apache.org> on 2010/04/16 13:21:25 UTC
[jira] Created: (PIVOT-460) Addtional maximized argument for
desktop applications
Addtional maximized argument for desktop applications
-----------------------------------------------------
Key: PIVOT-460
URL: https://issues.apache.org/jira/browse/PIVOT-460
Project: Pivot
Issue Type: New Feature
Components: wtk
Affects Versions: 1.4
Reporter: Alejandro Vilar
Priority: Minor
An additional argument like MAXIMIZED_ARGUMENT for desktop apps would be useful, allowing set the initial state of the AWT frame as maximized.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PIVOT-460) Addtional maximized argument for
desktop applications
Posted by "Alejandro Vilar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Vilar updated PIVOT-460:
----------------------------------
Attachment: maximize_argument_preferences.patch
Greg,
I was able to apply your patch and install UnxUtils, I'm submitting another patch based on yours, because whenever the frame is closed the x,y,width and height attributes will be saved ignoring if the window status is maximized, iconified or normal. For example if the app is closed while is maximized the location will be pointing to 0,0, the dimensions to the maximum bounds and when the application is loaded again it will be start maximized but when the user press the restore button the window will be restored to the maximum bounds with no changes apparently.
Regards
-A
> Addtional maximized argument for desktop applications
> -----------------------------------------------------
>
> Key: PIVOT-460
> URL: https://issues.apache.org/jira/browse/PIVOT-460
> Project: Pivot
> Issue Type: New Feature
> Components: wtk
> Affects Versions: 1.4
> Reporter: Alejandro Vilar
> Priority: Minor
> Fix For: 1.5
>
> Attachments: DesktopApplicationContext.java, maximize_argument_preferences.patch, maximized_argument(unified).patch, maximized_argument.patch, maximized_argument.patch
>
>
> An additional argument like MAXIMIZED_ARGUMENT for desktop apps would be useful, allowing set the initial state of the AWT frame as maximized.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIVOT-460) Addtional maximized argument for
desktop applications
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858173#action_12858173 ]
Greg Brown commented on PIVOT-460:
----------------------------------
I have committed this change. Please let me know if you see any issues with it.
> Addtional maximized argument for desktop applications
> -----------------------------------------------------
>
> Key: PIVOT-460
> URL: https://issues.apache.org/jira/browse/PIVOT-460
> Project: Pivot
> Issue Type: New Feature
> Components: wtk
> Affects Versions: 1.4
> Reporter: Alejandro Vilar
> Priority: Minor
> Fix For: 1.5
>
> Attachments: DesktopApplicationContext.java, maximized_argument(unified).patch, maximized_argument.patch, maximized_argument.patch
>
>
> An additional argument like MAXIMIZED_ARGUMENT for desktop apps would be useful, allowing set the initial state of the AWT frame as maximized.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PIVOT-460) Addtional maximized argument for
desktop applications
Posted by "Alejandro Vilar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Vilar updated PIVOT-460:
----------------------------------
Attachment: maximized_argument(unified).patch
Here is the patch in unified format, currently I'm using netbeans to apply the patch and works fine.
> Addtional maximized argument for desktop applications
> -----------------------------------------------------
>
> Key: PIVOT-460
> URL: https://issues.apache.org/jira/browse/PIVOT-460
> Project: Pivot
> Issue Type: New Feature
> Components: wtk
> Affects Versions: 1.4
> Reporter: Alejandro Vilar
> Priority: Minor
> Fix For: 1.5
>
> Attachments: DesktopApplicationContext.java, maximized_argument(unified).patch, maximized_argument.patch, maximized_argument.patch
>
>
> An additional argument like MAXIMIZED_ARGUMENT for desktop apps would be useful, allowing set the initial state of the AWT frame as maximized.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PIVOT-460) Addtional maximized argument for
desktop applications
Posted by "Alejandro Vilar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Vilar updated PIVOT-460:
----------------------------------
Attachment: maximized_argument.patch
Sorry for this, but I have to update the previous patch, it doesn't keeps the last maximized state in the user preferences, I'm attaching another patch.
Thanks
> Addtional maximized argument for desktop applications
> -----------------------------------------------------
>
> Key: PIVOT-460
> URL: https://issues.apache.org/jira/browse/PIVOT-460
> Project: Pivot
> Issue Type: New Feature
> Components: wtk
> Affects Versions: 1.4
> Reporter: Alejandro Vilar
> Priority: Minor
> Fix For: 1.5
>
> Attachments: DesktopApplicationContext.java, maximized_argument.patch
>
>
> An additional argument like MAXIMIZED_ARGUMENT for desktop apps would be useful, allowing set the initial state of the AWT frame as maximized.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIVOT-460) Addtional maximized argument for
desktop applications
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858027#action_12858027 ]
Greg Brown commented on PIVOT-460:
----------------------------------
Could you possibly resubmit the patch using unified diff format? You can just type "svn diff > maximized_argument.patch" in your trunk root directory.
> Addtional maximized argument for desktop applications
> -----------------------------------------------------
>
> Key: PIVOT-460
> URL: https://issues.apache.org/jira/browse/PIVOT-460
> Project: Pivot
> Issue Type: New Feature
> Components: wtk
> Affects Versions: 1.4
> Reporter: Alejandro Vilar
> Priority: Minor
> Fix For: 1.5
>
> Attachments: DesktopApplicationContext.java, maximized_argument.patch
>
>
> An additional argument like MAXIMIZED_ARGUMENT for desktop apps would be useful, allowing set the initial state of the AWT frame as maximized.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIVOT-460) Addtional maximized argument for
desktop applications
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858048#action_12858048 ]
Greg Brown commented on PIVOT-460:
----------------------------------
Were you able to apply the alternate patch I posted?
> Addtional maximized argument for desktop applications
> -----------------------------------------------------
>
> Key: PIVOT-460
> URL: https://issues.apache.org/jira/browse/PIVOT-460
> Project: Pivot
> Issue Type: New Feature
> Components: wtk
> Affects Versions: 1.4
> Reporter: Alejandro Vilar
> Priority: Minor
> Fix For: 1.5
>
> Attachments: DesktopApplicationContext.java, maximized_argument(unified).patch, maximized_argument.patch, maximized_argument.patch
>
>
> An additional argument like MAXIMIZED_ARGUMENT for desktop apps would be useful, allowing set the initial state of the AWT frame as maximized.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PIVOT-460) Addtional maximized argument for
desktop applications
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Brown updated PIVOT-460:
-----------------------------
Attachment: maximized_argument.patch
Actually, could you try applying this patch and see if it resolves your problem? Run this command in your trunk root:
patch -p0 < maximized_argument.patch
If you are on Windows and don't have the patch command, you can use this:
http://sourceforge.net/projects/unxutils/
Unzip it to c:\ and make sure that c:\usr\local\wbin is on your path.
> Addtional maximized argument for desktop applications
> -----------------------------------------------------
>
> Key: PIVOT-460
> URL: https://issues.apache.org/jira/browse/PIVOT-460
> Project: Pivot
> Issue Type: New Feature
> Components: wtk
> Affects Versions: 1.4
> Reporter: Alejandro Vilar
> Priority: Minor
> Fix For: 1.5
>
> Attachments: DesktopApplicationContext.java, maximized_argument.patch, maximized_argument.patch
>
>
> An additional argument like MAXIMIZED_ARGUMENT for desktop apps would be useful, allowing set the initial state of the AWT frame as maximized.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (PIVOT-460) Addtional maximized argument for
desktop applications
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Brown resolved PIVOT-460.
------------------------------
Fix Version/s: 1.5
Resolution: Fixed
I have applied the patch. Note that, while .java files are OK, patches are more commonly submitted as .patch files generated by the diff command. This makes it a little easier to scan the patch up front before applying it.
Thank you for your contribution!
> Addtional maximized argument for desktop applications
> -----------------------------------------------------
>
> Key: PIVOT-460
> URL: https://issues.apache.org/jira/browse/PIVOT-460
> Project: Pivot
> Issue Type: New Feature
> Components: wtk
> Affects Versions: 1.4
> Reporter: Alejandro Vilar
> Priority: Minor
> Fix For: 1.5
>
> Attachments: DesktopApplicationContext.java
>
>
> An additional argument like MAXIMIZED_ARGUMENT for desktop apps would be useful, allowing set the initial state of the AWT frame as maximized.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIVOT-460) Addtional maximized argument for
desktop applications
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858238#action_12858238 ]
Greg Brown commented on PIVOT-460:
----------------------------------
Patch applied. Let me know if you run into any other issues, and thanks for the submission!
> Addtional maximized argument for desktop applications
> -----------------------------------------------------
>
> Key: PIVOT-460
> URL: https://issues.apache.org/jira/browse/PIVOT-460
> Project: Pivot
> Issue Type: New Feature
> Components: wtk
> Affects Versions: 1.4
> Reporter: Alejandro Vilar
> Priority: Minor
> Fix For: 1.5
>
> Attachments: DesktopApplicationContext.java, maximize_argument_preferences.patch, maximized_argument(unified).patch, maximized_argument.patch, maximized_argument.patch
>
>
> An additional argument like MAXIMIZED_ARGUMENT for desktop apps would be useful, allowing set the initial state of the AWT frame as maximized.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PIVOT-460) Addtional maximized argument for
desktop applications
Posted by "Alejandro Vilar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Vilar updated PIVOT-460:
----------------------------------
Attachment: DesktopApplicationContext.java
This patch includes the MAXIMIZED_ARGUMENT constant and is also saved in the user preferences like other arguments.
> Addtional maximized argument for desktop applications
> -----------------------------------------------------
>
> Key: PIVOT-460
> URL: https://issues.apache.org/jira/browse/PIVOT-460
> Project: Pivot
> Issue Type: New Feature
> Components: wtk
> Affects Versions: 1.4
> Reporter: Alejandro Vilar
> Priority: Minor
> Attachments: DesktopApplicationContext.java
>
>
> An additional argument like MAXIMIZED_ARGUMENT for desktop apps would be useful, allowing set the initial state of the AWT frame as maximized.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira