[GitHub] [accumulo] andrewglowacki commented on a change in pull request #2337: Fix stuck batch writer on OutOfMemoryError (#2331)

[GitBox <gi...@apache.org>]

andrewglowacki commented on a change in pull request #2337:
URL: https://github.com/apache/accumulo/pull/2337#discussion_r740670731



##########
File path: core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java
##########
@@ -763,7 +763,7 @@ public void run() {
               log.trace("{} - binning {} mutations", Thread.currentThread().getName(),
                   mutationsToSend.size());
               addMutations(mutationsToSend);
-            } catch (Exception e) {
+            } catch (Throwable e) {
               updateUnknownErrors("Error processing mutation set", e);

Review comment:
       The Throwable is passed through to the client via updateUnknownErrors where it is re-thrown. The client can decide to halt the JVM if they so choose.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org