You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Gary Gregory <ga...@gmail.com> on 2012/03/28 18:14:13 UTC
[codec] getting to ready to RC 1.7
Hi All:
If there is anything you're itching to for for codec 1.7, now is the time.
I plan on doing an RC this week.
Gary
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [codec] getting to ready to RC 1.7
Posted by sebb <se...@gmail.com>.
On 28 March 2012 17:50, Thomas Neidhart <th...@gmail.com> wrote:
> On 03/28/2012 06:47 PM, sebb wrote:
>> On 28 March 2012 17:14, Gary Gregory <ga...@gmail.com> wrote:
>>> Hi All:
>>>
>>> If there is anything you're itching to for for codec 1.7, now is the time.
>>
>> Any comments on CODEC-96 ?
>> Base64 encode() method is no longer thread-safe, breaking clients
>> using it as a shared BinaryEncoder
>>
>> The patch restores thread-safety, but Clirr reports binary compat issues.
>> I think these are unlikely to be an actual problem, but this should be reviewed.
>
> I have reviewed your patch, see my comments attached to the issue.
Thanks, v. useful. I've updated the patch.
> I did not look into the clirr issues yet.
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [codec] getting to ready to RC 1.7
Posted by Thomas Neidhart <th...@gmail.com>.
On 03/28/2012 06:47 PM, sebb wrote:
> On 28 March 2012 17:14, Gary Gregory <ga...@gmail.com> wrote:
>> Hi All:
>>
>> If there is anything you're itching to for for codec 1.7, now is the time.
>
> Any comments on CODEC-96 ?
> Base64 encode() method is no longer thread-safe, breaking clients
> using it as a shared BinaryEncoder
>
> The patch restores thread-safety, but Clirr reports binary compat issues.
> I think these are unlikely to be an actual problem, but this should be reviewed.
I have reviewed your patch, see my comments attached to the issue. I did
not look into the clirr issues yet.
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [codec] getting to ready to RC 1.7
Posted by sebb <se...@gmail.com>.
On 28 March 2012 19:29, Gary Gregory <ga...@gmail.com> wrote:
> On Wed, Mar 28, 2012 at 12:47 PM, sebb <se...@gmail.com> wrote:
>
>> On 28 March 2012 17:14, Gary Gregory <ga...@gmail.com> wrote:
>> > Hi All:
>> >
>> > If there is anything you're itching to for for codec 1.7, now is the
>> time.
>>
>> Any comments on CODEC-96 ?
>> Base64 encode() method is no longer thread-safe, breaking clients
>> using it as a shared BinaryEncoder
>>
>> The patch restores thread-safety, but Clirr reports binary compat issues.
>> I think these are unlikely to be an actual problem, but this should be
>> reviewed.
>>
>
> If someone wants to work on that, be my guest.
I've already done the work on the patch.
Thomas has reviewed it and I've updated the patch.
> We've been strict about BC so I this might have to wait for 2.0 though.
> Unless we can show that breaking BC should not affect normal users.
Which is exactly my point.
It does break BC, but IMO the breakage is in the internal API.
However, that needs to be reviewed by others to check that the
external API is not affected.
>
>>
>> Also CODEC-137 (website javadoc link) needs fixing.
>>
>
> I think this is already taken care of in trunk where the link is for Codec
> 1.7.
>
> Gary
>
>>
>> > I plan on doing an RC this week.
>> >
>> > Gary
>> >
>> > --
>> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> > JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
>> > Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
>> > Blog: http://garygregory.wordpress.com
>> > Home: http://garygregory.com/
>> > Tweet! http://twitter.com/GaryGregory
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [codec] getting to ready to RC 1.7
Posted by Gary Gregory <ga...@gmail.com>.
On Wed, Mar 28, 2012 at 12:47 PM, sebb <se...@gmail.com> wrote:
> On 28 March 2012 17:14, Gary Gregory <ga...@gmail.com> wrote:
> > Hi All:
> >
> > If there is anything you're itching to for for codec 1.7, now is the
> time.
>
> Any comments on CODEC-96 ?
> Base64 encode() method is no longer thread-safe, breaking clients
> using it as a shared BinaryEncoder
>
> The patch restores thread-safety, but Clirr reports binary compat issues.
> I think these are unlikely to be an actual problem, but this should be
> reviewed.
>
If someone wants to work on that, be my guest.
We've been strict about BC so I this might have to wait for 2.0 though.
Unless we can show that breaking BC should not affect normal users.
>
> Also CODEC-137 (website javadoc link) needs fixing.
>
I think this is already taken care of in trunk where the link is for Codec
1.7.
Gary
>
> > I plan on doing an RC this week.
> >
> > Gary
> >
> > --
> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> > Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [codec] getting to ready to RC 1.7
Posted by sebb <se...@gmail.com>.
On 28 March 2012 17:14, Gary Gregory <ga...@gmail.com> wrote:
> Hi All:
>
> If there is anything you're itching to for for codec 1.7, now is the time.
Any comments on CODEC-96 ?
Base64 encode() method is no longer thread-safe, breaking clients
using it as a shared BinaryEncoder
The patch restores thread-safety, but Clirr reports binary compat issues.
I think these are unlikely to be an actual problem, but this should be reviewed.
Also CODEC-137 (website javadoc link) needs fixing.
> I plan on doing an RC this week.
>
> Gary
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org