You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "FrankYang0529 (via GitHub)" <gi...@apache.org> on 2026/10/07 05:20:45 UTC
[PR] Go SDK: answer the Dag-parsing request from Serve [airflow]
FrankYang0529 opened a new pull request, #74391:
URL: https://github.com/apache/airflow/pull/74391
Implement [Go SDK: Answer the Dag-parsing request from Serve](https://github.com/orgs/apache/projects/499/views/7?pane=issue&itemId=248987223).
- `Serve` answers a `DagFileParseRequest` with one `DagFileParsingResult`. The result holds the Dags declared with `airflow.Dag` that the bundle registered, in registration order. The result leaves out the Dag of a task handler, because that Dag comes from a Python Dag file that is parsed separately.
- If a Dag fails to serialize, the result gets an import error that names that Dag.
- In core, when a Lang-SDK runtime exits without a parse result, the import error now includes the first 5 and the last 15 lines of the runtime's stderr.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
For user-facing UI changes, please attach before/after screenshots (or a short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [X] Yes - Claude Code
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Go SDK: answer the Dag-parsing request from Serve [airflow]
Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 merged PR #74391:
URL: https://github.com/apache/airflow/pull/74391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Go SDK: answer the Dag-parsing request from Serve [airflow]
Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on PR #74391:
URL: https://github.com/apache/airflow/pull/74391#issuecomment-6034845514
Pushed a few follow-up commits on top:
- Dropped the task-sdk and core stderr-excerpt changes, so this PR is Go SDK only. They can go in a separate PR if needed.
- Removed `bundle.Registry`. `execution.Serve` takes `bundle.Bundle` again and checks for `bundle.DagSerializer` in the parse branch. The adapter is now `coordinatorSource{*taskHandlerMap; dags *dagMap}`, the same shape as `manifestSource` in #74342.
- The parse result now replies on the request id and exits, the same as the TS runtime and ADR 0003. The ack wait and its test are removed.
- `parseDags` returns an empty result when the bundle has no Dags, and logs `Received Dag parse request` / `Parse-mode response` at info, the same as TS.
- `serializeRecovering` now logs the panic stack.
- Trimmed the comments added in this PR.
- Native Dag task lookup in `LookupTask` will be fixed in #74342.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org