You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by ciaranj <gi...@git.apache.org> on 2014/04/28 18:01:09 UTC
[GitHub] cordova-plugin-inappbrowser pull request: Only Navigate *after* th...
GitHub user ciaranj opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/42
Only Navigate *after* the webview has been transitioned to visually
* There were issues closing the presented UIWebView from within loadstart events
(The infamous "while a presentation is in progress!" warning was displayed in the logs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ciaranj/cordova-plugin-inappbrowser navigate_after_show
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/42.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #42
----
commit b2123c2c0902d83d8393afb9da4e40b77f93d060
Author: ciaranj <ci...@gmail.com>
Date: 2014-04-28T15:01:23Z
Only Navigate *after* the webview has been transitioned to visually
* There were issues closing the presented UIWebView from within loadstart events
(The infamous "while a presentation is in progress!" warning was displayed in the logs)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Only Navigate *after* th...
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/42#issuecomment-47384434
@shazron - should this be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Only Navigate *after* th...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/42#issuecomment-47393202
Also Github says there are merge conflicts -- up to the PR submitter to resolve.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Only Navigate *after* th...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/42#issuecomment-42088711
Filed issue: https://issues.apache.org/jira/browse/CB-6624
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Only Navigate *after* th...
Posted by ciaranj <gi...@git.apache.org>.
Github user ciaranj commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/42#issuecomment-47395736
Meh, makes not odds to me if you merge it or not (there were no conflicts when I submitted it) I don't need the fix for anything I'm doing ;) Feel free to close and leave the issue in the wild :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Only Navigate *after* th...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/42
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---