You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Makundi (JIRA)" <ji...@apache.org> on 2010/01/14 16:22:54 UTC

[jira] Created: (WICKET-2678) isEnabled called in AjaxRequestTarget for Behaviors even if component is not Visible in hierarchy

 isEnabled called in AjaxRequestTarget for Behaviors even if component is not Visible in hierarchy
--------------------------------------------------------------------------------------------------

                 Key: WICKET-2678
                 URL: https://issues.apache.org/jira/browse/WICKET-2678
             Project: Wicket
          Issue Type: Sub-task
          Components: wicket
    Affects Versions: 1.4.5
            Reporter: Martin Makundi


AjaxRequestTarget calls isEnabled for behaviors even if the related component is not visible in hierarchy.

Exlpicit problems: hide using ajax a panel containing datefield having datepicker behavior and the javascript will crash in browser. Mozilla will survive but ie8 will not execute ajaxpostcallhandlers.

Following code should probably call component.isVisibleInHierarchy instead of just isVisible:

public class AjaxRequestTarget implements IPageRequestTarget
{
...
		if (component instanceof MarkupContainer)
		{
			((MarkupContainer)component).visitChildren(new Component.IVisitor<Component>()
			{
				public Object component(Component component)
				{
					if (component.isVisible())
					{
						component.renderHead(header);
						return CONTINUE_TRAVERSAL;
					}


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-2678) isEnabled called in AjaxRequestTarget for Behaviors even if component is not Visible in hierarchy

Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juergen Donnerstag resolved WICKET-2678.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5-M1
                   1.4.6
         Assignee: Juergen Donnerstag

thanks

>  isEnabled called in AjaxRequestTarget for Behaviors even if component is not Visible in hierarchy
> --------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-2678
>                 URL: https://issues.apache.org/jira/browse/WICKET-2678
>             Project: Wicket
>          Issue Type: Sub-task
>          Components: wicket
>    Affects Versions: 1.4.5
>            Reporter: Martin Makundi
>            Assignee: Juergen Donnerstag
>             Fix For: 1.4.6, 1.5-M1
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> AjaxRequestTarget calls isEnabled for behaviors even if the related component is not visible in hierarchy.
> Exlpicit problems: hide using ajax a panel containing datefield having datepicker behavior and the javascript will crash in browser. Mozilla will survive but ie8 will not execute ajaxpostcallhandlers.
> Following code should probably call component.isVisibleInHierarchy instead of just isVisible:
> public class AjaxRequestTarget implements IPageRequestTarget
> {
> ...
> 		if (component instanceof MarkupContainer)
> 		{
> 			((MarkupContainer)component).visitChildren(new Component.IVisitor<Component>()
> 			{
> 				public Object component(Component component)
> 				{
> 					if (component.isVisible())
> 					{
> 						component.renderHead(header);
> 						return CONTINUE_TRAVERSAL;
> 					}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.