[GitHub] [pinot] dang-stripe commented on issue #8948: Stuck unassigned segments after metadata push while controller is shutting down

[GitBox <gi...@apache.org>]

dang-stripe commented on issue #8948:
URL: https://github.com/apache/pinot/issues/8948#issuecomment-1165863197

   Thanks for following up - we already fixed the segments by deleting them so can't easily reproduce atm. I looked at the code and it seems like we'd hit this block? https://github.com/apache/pinot/blob/release-0.9.0/pinot-controller/src/main/java/org/apache/pinot/controller/api/upload/ZKOperator.java#L95 Which seems to try to refresh existing segments if there were any errors in the last upload.
   
   It's a little unclear to me where the external view + ideal state would get updated here when the segment is refreshed. There also seems to be a check for `enableParallelPushProtection` which defaults to false: https://github.com/apache/pinot/blob/release-0.9.0/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java#L527 Is that something we'd want to enable to ensure refresh occurs?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org