[jira] [Commented] (SLING-4397) JDBC Datasource: Add support for system properties

["Chetan Mehrotra (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-4397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313670#comment-14313670 ] 

Chetan Mehrotra commented on SLING-4397:
----------------------------------------

[~amitjain] It would be better to make use of Framework properties instead of system properties. With Sling the framework property can be set at command line itself via {{-D}} [commandline option|http://sling.apache.org/documentation/the-sling-engine/the-sling-launchpad.html#command-line-options]. 

This would however not work with Webapp based deployment. Probably that should be fine as in such deplyments JNDI based DataSource would be used

> JDBC Datasource: Add support for system properties
> --------------------------------------------------
>
>                 Key: SLING-4397
>                 URL: https://issues.apache.org/jira/browse/SLING-4397
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Amit Jain
>             Fix For: DataSource Provider 1.0.0
>
>
> Currently, the DB properties are configured through a file. For db connection properties like url, username, password it is better to provide an override mechanism through the system properties. 
> This would enable applications to bundle a default config which can be overridden through command-line.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)