[GitHub] sdedic commented on a change in pull request #997: Simplifying semantic highlighter.

[GitBox <gi...@apache.org>]

sdedic commented on a change in pull request #997: Simplifying semantic highlighter.
URL: https://github.com/apache/incubator-netbeans/pull/997#discussion_r234193291
 
 

 ##########
 File path: java/java.editor.base/src/org/netbeans/modules/java/editor/base/semantic/SemanticHighlighterBase.java
 ##########
 @@ -655,12 +553,11 @@ private void addModifiers(Element decl, Collection<ColoringAttributes> c) {
 
         private static final Set<Kind> LITERALS = EnumSet.of(Kind.BOOLEAN_LITERAL, Kind.CHAR_LITERAL, Kind.DOUBLE_LITERAL, Kind.FLOAT_LITERAL, Kind.INT_LITERAL, Kind.LONG_LITERAL, Kind.STRING_LITERAL);
 
-        private void handlePossibleIdentifier(TreePath expr, Collection<UseTypes> type) {
-            handlePossibleIdentifier(expr, type, null, false, false);
+        private void handlePossibleIdentifier(TreePath expr, boolean declaration) {
+            handlePossibleIdentifier(expr, declaration, null, false, false);
         }
         
-        private void handlePossibleIdentifier(TreePath expr, Collection<UseTypes> type, Element decl, boolean providesDecl, boolean nct) {
-            
+        private void handlePossibleIdentifier(TreePath expr, boolean declaration, Element decl, boolean providesDecl, boolean nct) {
 
 Review comment:
   param `providesDecl` seems to be redundant. There are two calls, one always provides null and one always non-null `decl` parameter.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists