You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Yonik Seeley (JIRA)" <ji...@apache.org> on 2015/04/23 19:53:46 UTC

[jira] [Commented] (SOLR-7296) Reconcile faceting implementations

    [ https://issues.apache.org/jira/browse/SOLR-7296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509444#comment-14509444 ] 

Yonik Seeley commented on SOLR-7296:
------------------------------------

bq. I took a deeper look at the new Facet Module (ported from Heliosearch) and I like it a whole lot!

Thanks David!  IMO, it's still early... the details of how things work internally should morph according to the features we want in faceting (and we're just getting started... there's so much more we can do there).  So although what we have for the JSON Facet API will no longer be "experimental" for 5.2, I think the Java classes should remain experimental for longer.

The Java classes are also "early" from the perspective that some obvious stuff hasn't been done:
- move string literals to constants
- move certain classes out to their own files (I tend to start prototyping class hierarchies in a single file... much easier to morph early on)

> Reconcile faceting implementations
> ----------------------------------
>
>                 Key: SOLR-7296
>                 URL: https://issues.apache.org/jira/browse/SOLR-7296
>             Project: Solr
>          Issue Type: Task
>          Components: faceting
>            Reporter: Steve Molloy
>
> SOLR-7214 introduced a new way of controlling faceting, the unmbrella SOLR-6348 brings a lot of improvements in facet functionality, namely around pivots. Both make a lot of sense from a user perspective, but currently have completely different implementations. With the analytics components, this makes 3 implementation of the same logic, which is bound to behave differently as time goes by. We should reconcile all implementations to ease maintenance and offer consistent behaviour no matter how parameters are passed to the API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org