You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Gavin (JIRA)" <ji...@apache.org> on 2018/08/01 06:22:27 UTC

[jira] [Issue Comment Deleted] (HBASE-18026) ProtobufUtil seems to do extra array copying

     [ https://issues.apache.org/jira/browse/HBASE-18026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gavin updated HBASE-18026:
--------------------------
    Comment: was deleted

(was: A comment with security level 'jira-users' was removed.)

> ProtobufUtil seems to do extra array copying
> --------------------------------------------
>
>                 Key: HBASE-18026
>                 URL: https://issues.apache.org/jira/browse/HBASE-18026
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.3.2
>            Reporter: Vincent Poon
>            Assignee: Vincent Poon
>            Priority: Minor
>             Fix For: 1.4.0, 1.2.6, 1.3.2, 1.1.11, 2.0.0
>
>         Attachments: HBASE-18026.addendum.patch, HBASE-18026.branch-1.v1.patch, HBASE-18026.master.v1.patch
>
>
> In ProtobufUtil, the protobuf fields are copied into an array using toByteArray().  These are then passed into the KeyValue constructor which does another copy.
> It seems like we can avoid a copy here by using HBaseZeroCopyByteString#zeroCopyGetBytes() ?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)