You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Nick Kew <ni...@webthing.com> on 2007/09/02 00:20:19 UTC
Re: svn commit: r571879 -
/httpd/httpd/trunk/modules/proxy/mod_proxy_connect.c
On Sat, 01 Sep 2007 21:42:30 -0000
jim@apache.org wrote:
> Author: jim
> Date: Sat Sep 1 14:42:30 2007
> New Revision: 571879
>
> URL: http://svn.apache.org/viewvc?rev=571879&view=rev
> Log:
> Clean up nasty formatting
ObPedant:
> 14:42:30 2007 @@ -113,8 +113,8 @@
> /* we break the URL into host, port, uri */
> if (APR_SUCCESS != apr_uri_parse_hostinfo(p, url, &uri)) {
> - return ap_proxyerror(r, HTTP_BAD_REQUEST,
> - apr_pstrcat(p, "URI cannot be parsed: ", url,
> NULL));
> + return ap_proxyerror(r, HTTP_BAD_REQUEST, apr_pstrcat(p,
> + "URI cannot be parsed: ", url, NULL));
The second arg to ap_pstrcat is presented as a new arg to ap_proxyerror.
The old formatting was better.
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
Re: svn commit: r571879 - /httpd/httpd/trunk/modules/proxy/mod_proxy_connect.c
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Nick Kew wrote:
> ObPedant:
>
>> 14:42:30 2007 @@ -113,8 +113,8 @@
>> /* we break the URL into host, port, uri */
>> if (APR_SUCCESS != apr_uri_parse_hostinfo(p, url, &uri)) {
>> - return ap_proxyerror(r, HTTP_BAD_REQUEST,
>> - apr_pstrcat(p, "URI cannot be parsed: ", url,
>> NULL));
>> + return ap_proxyerror(r, HTTP_BAD_REQUEST, apr_pstrcat(p,
>> + "URI cannot be parsed: ", url, NULL));
>
> The second arg to ap_pstrcat is presented as a new arg to ap_proxyerror.
> The old formatting was better.
+1 to niq's observation
- this is now quite illegible in terms of how it is doing what it does.