You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "AntoinePrv (via GitHub)" <gi...@apache.org> on 2025/10/21 14:58:35 UTC

[I] [C++][Parquet] Unpack function epilog [arrow]

AntoinePrv opened a new issue, #47895:
URL: https://github.com/apache/arrow/issues/47895

   ### Describe the enhancement requested
   
   Right now, the `unpack` family of functions extract fewer elements than requested.
   This is because it relies on batch extraction that must process many inputs at once.
   Instead the `BitReader::GetBatch` is responsible for handling inputs before (prolog) and after (epilog) `unpack`.
   
   This has two downsides:
   - It makes the general parquet C++ logic harder to understand, as related functions are spread apart;
   - I makes `unpack` harder to (re)use as it does not fully extract all that is needed. In particular, it makes it hard to iterate on these functions because the tests/benchmarks would need to adapt to the number of element that the function can work with.
   
   The prolog and epilog should be moved to the `unpack` functions so that one function is fully responsible for unpacking integers without extra complexity.
   
   ### Component(s)
   
   C++, Parquet


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++][Parquet] Unpack function epilog [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #47895:
URL: https://github.com/apache/arrow/issues/47895#issuecomment-3460778655

   Issue resolved by pull request 47896
   https://github.com/apache/arrow/pull/47896


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++][Parquet] Unpack function epilog [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou closed issue #47895: [C++][Parquet] Unpack function epilog
URL: https://github.com/apache/arrow/issues/47895


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org