You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by shroman <gi...@git.apache.org> on 2017/02/10 06:59:13 UTC
[GitHub] incubator-rocketmq-site pull request #7: Changes to the text on specifying n...
GitHub user shroman opened a pull request:
https://github.com/apache/incubator-rocketmq-site/pull/7
Changes to the text on specifying name server list.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shroman/incubator-rocketmq-site namesrv-feeding
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq-site/pull/7.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7
----
commit 9df8534124af94ffb9c5ef2a405211d518d64ad9
Author: shtykh_roman <rs...@yahoo.com>
Date: 2017-02-10T06:57:35Z
Changes to the text on specifying name server list.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-site issue #7: Changes to the text on specifying name ser...
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/7
@lizhanhui Some small changes. Just as a variant.
Also, I don't think `HTTP endpoint` should be mentioned unless there is a description on how a user can configure its own endpoint.
Another thing (not related to the docs) I thought is if a broker can be configured via a config file, why not to allow the same to producers/consumers?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-site issue #7: Changes to the text on specifying name ser...
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/7
"This, IMO, is the best way to configure name server addresses. Maybe we should add this endpoint to rocketmq-console project."
Yes, absolutely. But my point is the user have no idea what this endpoint is (I failed to access your default one. Not accessible outside of China?) or how to set up its own :)
\U0001f44d for `rocketmq.conf`. I would also get rid of environment variable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-site issue #7: Changes to the text on specifying name ser...
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/7
This PR has been merged. @shroman you may close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-site issue #7: Changes to the text on specifying name ser...
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/7
sure, I will create a JIRA issue so that this issue is not lost.
And discussing in the ml is always good ;)
Basically, that is all from me. You can merge or close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-site issue #7: Changes to the text on specifying name ser...
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/7
@shroman We may create a JIRA ticket and thread in mailing list to follow this idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-site issue #7: Changes to the text on specifying name ser...
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/7
> "Also, I don't think HTTP endpoint should be mentioned unless there is a description on how a user can configure its own endpoint."
This, IMO, is the best way to configure name server addresses. Maybe we should add this endpoint to rocketmq-console project.
> "Another thing (not related to the docs) I thought is if a broker can be configured via a config file, why not to allow the same to producers/consumers?"
Good point. I think we may make the client search configuration files in classpath as many projects do, say a default.conf file containing all default values and rocketmq.conf for application user to override.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-site issue #7: Changes to the text on specifying name ser...
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/7
I'll check and merge. It looks I do not have permission to close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-site pull request #7: Changes to the text on specifying n...
Posted by shroman <gi...@git.apache.org>.
Github user shroman closed the pull request at:
https://github.com/apache/incubator-rocketmq-site/pull/7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---