You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/28 02:28:28 UTC

[GitHub] [arrow-rs] HaoYang670 commented on pull request #1951: Add add_dyn for DictionaryArray support

HaoYang670 commented on PR #1951:
URL: https://github.com/apache/arrow-rs/pull/1951#issuecomment-1168143352

   > I am surprised at the amount of code required for this but I tried and couldn't really figure out any better way (as the macros are basically implementing all the type dispatch to then call `add`).
   
   I have tried to use nested macro with repetition (the `$$`)  which could reduce some code but make the code less readable. Also this feature has not been stabilized (will be stable in 1.63.0). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org