You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/25 06:12:44 UTC
[GitHub] [incubator-doris] morrySnow opened a new pull request, #9764: [style] (fe) wrap and whitespace rules
morrySnow opened a new pull request, #9764:
URL: https://github.com/apache/incubator-doris/pull/9764
change below rules' severity to error and fix original code error:
- EmptyBlock
- EmptyCatchBlock
- LeftCurly
- RightCurly
- IllegalTokenText
- MultipleVariableDeclarations
- OneStatementPerLine
- StringLiteralEquality
- UnusedLocalVariable
- Indentation
- OuterTypeFilename
- MethodParamPad
- GenericWhitespace
- NoWhitespaceBefore
- OperatorWrap
- ParenPad
- WhitespaceAfter
- WhitespaceAround
# Proposed changes
Issue Number: close #9405
## Checklist(Required)
1. Does it affect the original behavior: No
2. Has unit tests been added: No Need
3. Has document been added or modified: No Need
4. Does it need to update dependencies: No
5. Are there any changes that cannot be rolled back: No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9764: [style] (fe) wrap and whitespace rules
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9764:
URL: https://github.com/apache/incubator-doris/pull/9764#issuecomment-1138315637
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a diff in pull request #9764: [style] (fe) wrap and whitespace rules
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #9764:
URL: https://github.com/apache/incubator-doris/pull/9764#discussion_r882264225
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/BinaryPredicate.java:
##########
@@ -134,11 +134,21 @@ public Operator converse() {
}
}
- public boolean isEquivalence() { return this == EQ || this == EQ_FOR_NULL; };
+ public boolean isEquivalence() {
+ return this == EQ || this == EQ_FOR_NULL;
+ }
+
+ ;
+
+ public boolean isUnNullSafeEquivalence() {
+ return this == EQ;
+ }
- public boolean isUnNullSafeEquivalence() { return this == EQ; };
+ ;
Review Comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #9764: [style] (fe) wrap and whitespace rules
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #9764:
URL: https://github.com/apache/incubator-doris/pull/9764#issuecomment-1138316177
I will merge this PR quickly to avoid further conflicts with other PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #9764: [style] (fe) wrap and whitespace rules
Posted by GitBox <gi...@apache.org>.
morningman merged PR #9764:
URL: https://github.com/apache/incubator-doris/pull/9764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morrySnow commented on pull request #9764: [style] (fe) wrap and whitespace rules
Posted by GitBox <gi...@apache.org>.
morrySnow commented on PR #9764:
URL: https://github.com/apache/incubator-doris/pull/9764#issuecomment-1136772363
just like step 1 #9460 , all fe check style error is not related to the rules this patch care about
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a diff in pull request #9764: [style] (fe) wrap and whitespace rules
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #9764:
URL: https://github.com/apache/incubator-doris/pull/9764#discussion_r882264236
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/BinaryPredicate.java:
##########
@@ -134,11 +134,21 @@ public Operator converse() {
}
}
- public boolean isEquivalence() { return this == EQ || this == EQ_FOR_NULL; };
+ public boolean isEquivalence() {
+ return this == EQ || this == EQ_FOR_NULL;
+ }
+
+ ;
Review Comment:
remove
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/BinaryPredicate.java:
##########
@@ -134,11 +134,21 @@ public Operator converse() {
}
}
- public boolean isEquivalence() { return this == EQ || this == EQ_FOR_NULL; };
+ public boolean isEquivalence() {
+ return this == EQ || this == EQ_FOR_NULL;
+ }
+
+ ;
+
+ public boolean isUnNullSafeEquivalence() {
+ return this == EQ;
+ }
- public boolean isUnNullSafeEquivalence() { return this == EQ; };
+ ;
Review Comment:
remove
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/BinaryPredicate.java:
##########
@@ -134,11 +134,21 @@ public Operator converse() {
}
}
- public boolean isEquivalence() { return this == EQ || this == EQ_FOR_NULL; };
+ public boolean isEquivalence() {
+ return this == EQ || this == EQ_FOR_NULL;
+ }
+
+ ;
Review Comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9764: [style] (fe) wrap and whitespace rules
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9764:
URL: https://github.com/apache/incubator-doris/pull/9764#issuecomment-1138315670
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org