[GitHub] [ozone] kerneltime commented on a diff in pull request #3912: HDDS-7419. Integrate the GetKeyInfo API to OFS

[GitBox <gi...@apache.org>]

kerneltime commented on code in PR #3912:
URL: https://github.com/apache/ozone/pull/3912#discussion_r1009881043


##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -1698,7 +1698,17 @@ public OzoneInputStream readFile(String volumeName, String bucketName,
         .setSortDatanodesInPipeline(topologyAwareReadEnabled)
         .setLatestVersionLocation(getLatestVersionLocation)
         .build();
-    OmKeyInfo keyInfo = ozoneManagerClient.lookupFile(keyArgs);
+    final OmKeyInfo keyInfo;
+    if (omVersion.compareTo(OzoneManagerVersion.OPTIMIZED_GET_KEY_INFO) >= 0) {
+      keyInfo = ozoneManagerClient.getKeyInfo(keyArgs, false)
+          .getKeyInfo();
+      if (!keyInfo.isFile()) {

Review Comment:
   Would it be possible to reuse `getKeyInfo` and check `isFile` if there was no exception (client used lookup and it failed)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org